Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] WasmBuildTests NativeBuild_WithDeployOnBuild_UsedByVS is failing and will be disabled #84722

Closed
lewing opened this issue Apr 12, 2023 · 4 comments · Fixed by #85009
Closed

[wasm] WasmBuildTests NativeBuild_WithDeployOnBuild_UsedByVS is failing and will be disabled #84722

lewing opened this issue Apr 12, 2023 · 4 comments · Fixed by #85009
Assignees
@radical
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone
8.0.0

Comments

@lewing
Copy link
Member

lewing commented Apr 12, 2023

The skia dependency is old and the template doesn't build on preview3 sdk.
@lewing lewing added arch-wasm WebAssembly architecture area-Build-mono labels Apr 12, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 12, 2023
@ghost
Copy link

ghost commented Apr 12, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The skia dependency is old and the template doesn't build on preview3 sdk.

Author: lewing
Assignees: radical
Labels:

arch-wasm, area-Build-mono
Milestone: -

@lewing
Copy link
Member Author

lewing commented Apr 12, 2023

#84698 has context

@lewing lewing added this to the 8.0.0 milestone Apr 12, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Apr 12, 2023
@ivanpovazan ivanpovazan mentioned this issue Apr 14, 2023
Merged
@lewing
Copy link
Member Author

lewing commented Apr 14, 2023

It appears to be a problem with the blazor templates but I haven't had time to look into it yet and we can't fix it here

@lewing
Copy link
Member Author

lewing commented Apr 14, 2023 

      []   Restored C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj (in 3.34 sec).
      [] C:\helix\work\workitem\e\dotnet-latest\sdk\8.0.100-preview.4.23212.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(287,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1001: Identifier expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1002: ; expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,52): error CS1526: A new expression requires an argument list or (), [], or {} after type [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] 
      [] Build FAILED.
      [] 
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1001: Identifier expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1002: ; expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,52): error CS1526: A new expression requires an argument list or (), [], or {} after type [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      []     0 Warning(s)
      []     3 Error(s)

@lewing lewing changed the title [wasm] WasmBuildTests NativeBuild_WithDeployOnBuild_UsedByVS is disabled [wasm] WasmBuildTests NativeBuild_WithDeployOnBuild_UsedByVS is failing and will be disabled Apr 14, 2023
@radical radical mentioned this issue Apr 18, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 18, 2023
radical added a commit to radical/runtime that referenced this issue Apr 18, 2023
@radical
[wasm] WBT: Re-enable previously disabled test
8253a6d 
`NativeBuild_WithDeployOnBuild_UsedByVS`

The filed issue possibly incorrectly identified the issue.
```
      []   Restored C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj (in 3.34 sec).
      [] C:\helix\work\workitem\e\dotnet-latest\sdk\8.0.100-preview.4.23212.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(287,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1001: Identifier expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1002: ; expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,52): error CS1526: A new expression requires an argument list or (), [], or {} after type [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      []
      [] Build FAILED.
      []
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1001: Identifier expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1002: ; expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,52): error CS1526: A new expression requires an argument list or (), [], or {} after type [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      []     0 Warning(s)
      []     3 Error(s)
```

This error has been seen intermittently seen before, and is likely
caused by `Program.cs` having some error messages instead of the code.

Fixes dotnet#84722
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

[wasm] WBT: Re-enable previously disabled test radical/runtime
2 participants
@radical @lewing