-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0][PERF] Backport python pipeline changes for performance tests #108412
[release/9.0][PERF] Backport python pipeline changes for performance tests #108412
Conversation
…lude dashes, fixing their passing into the new perf flow added in commit b14e2f5. (dotnet#108038)
Tagging subscribers to this area: @hoyosjs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we will want to watch after this goes in to make sure there are not any minor breaks.
Can we get this merged @carlossanlop, or is there someone we else we should ask? It is a performance infra only change and I am not seeing a release/9.0-staging branch. |
@jeffschwMSFT Could you help get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we can treat this as tell mode
@DrewScoggins please take a look at the PR failures - if unrelated, I can help merge |
One is a timeout in OleDB tests, and the other is a failure in the emcc for a WASM AOT test. These changes do not impact any files in the src folder, and also do not touch the configs for any of the unit tests. So in my opinion I do not believe that these failing tests are related to our change. |
Thanks for your help Jeff! |
This PR backports three changes to release/9.0 so it can make use of the work that moved a lot of the logic out of our yaml files and into python for performance testing:
Part of this work moved a lot of the pipeline logic out of the runtime repo and into the performance repo, so this change will help prevent us from having to make future changes to the release/9.0 branch.