Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0][PERF] Backport python pipeline changes for performance tests #108412

Conversation

caaavik-msft
Copy link
Contributor

This PR backports three changes to release/9.0 so it can make use of the work that moved a lot of the logic out of our yaml files and into python for performance testing:

Part of this work moved a lot of the pipeline logic out of the runtime repo and into the performance repo, so this change will help prevent us from having to make future changes to the release/9.0 branch.

Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we will want to watch after this goes in to make sure there are not any minor breaks.

@LoopedBard3
Copy link
Member

Can we get this merged @carlossanlop, or is there someone we else we should ask? It is a performance infra only change and I am not seeing a release/9.0-staging branch.

@DrewScoggins
Copy link
Member

@jeffschwMSFT Could you help get this merged?

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can treat this as tell mode

cc @carlossanlop

@jeffschwMSFT jeffschwMSFT added the Servicing-approved Approved for servicing release label Oct 4, 2024
@jeffschwMSFT jeffschwMSFT added this to the 9.0.0 milestone Oct 4, 2024
@jeffschwMSFT
Copy link
Member

@DrewScoggins please take a look at the PR failures - if unrelated, I can help merge

@DrewScoggins
Copy link
Member

One is a timeout in OleDB tests, and the other is a failure in the emcc for a WASM AOT test. These changes do not impact any files in the src folder, and also do not touch the configs for any of the unit tests.

So in my opinion I do not believe that these failing tests are related to our change.

@DrewScoggins
Copy link
Member

Thanks for your help Jeff!

@jeffschwMSFT jeffschwMSFT merged commit 48dfbed into dotnet:release/9.0 Oct 4, 2024
10 of 16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants