Use default timeout of 30s. #108835
Merged
Use default timeout of 30s. #108835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffschwMSFT
approved these changes
Oct 14, 2024
jeffschwMSFT
added
Servicing-approved
|
@pavelsavara @radekdoulik please provide a review and sign off today, as |
pavelsavara
approved these changes
Oct 15, 2024
|
@carlossanlop, approved, will it make it? (edit: I don't have merge rights) |
radekdoulik
approved these changes
Oct 15, 2024
This was referenced Oct 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #108723 to release/9.0
Customer Impact
This impacts only testing with WasmBuildTests on WASM. We have problems with time outs and we mitigated the issue on net10 by setting the timeout of launching the Playwright browser to default value (30s). Net9 is still caught in #107771, so it’s worth aligning the change.
Regression
Testing
CI
Risk
Low, it's only an infra change. It can in the worst case cause a slightly longer runs of CI.