Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Span<byte> overloads for ProtectedData #109529

Merged
merged 18 commits into from
Nov 8, 2024
Merged

Add Span<byte> overloads for ProtectedData #109529

merged 18 commits into from
Nov 8, 2024

Conversation

ChadNedzlek
Copy link
Member

@ChadNedzlek ChadNedzlek commented Nov 5, 2024 •
edited by bartonjs
Loading

ProtectedData only has allocating byte[] overloads, but in .NET 5+, Span overloads can avoid allocations.

Resolves #108734

@ChadNedzlek
Add Span<byte> overloads for ProtectedData
ed92836 
ProtectedData only has allocating byte[] overloads,
but in .NET 5+, Span<byte> overloads can avoid allocations.
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

bartonjs
bartonjs reviewed Nov 5, 2024
View reviewed changes
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs Outdated Show resolved Hide resolved
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs Show resolved Hide resolved
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs Outdated Show resolved Hide resolved
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs Outdated Show resolved Hide resolved
...System.Security.Cryptography.ProtectedData/src/System/Security/Cryptography/ProtectedData.cs Outdated Show resolved Hide resolved
src/libraries/System.Security.Cryptography.ProtectedData/tests/ArrayProtectedDataTests.cs Outdated Show resolved Hide resolved
src/libraries/System.Security.Cryptography.ProtectedData/tests/SpanProtectedDataTests.cs Outdated Show resolved Hide resolved
src/libraries/System.Security.Cryptography.ProtectedData/tests/SpanProtectedDataTests.cs Outdated Show resolved Hide resolved
src/libraries/System.Security.Cryptography.ProtectedData/tests/SpanProtectedDataTests.cs Outdated Show resolved Hide resolved
src/libraries/System.Security.Cryptography.ProtectedData/tests/SpanProtectedDataTests.cs Outdated Show resolved Hide resolved
@danzuep
Copy link

danzuep commented Nov 5, 2024

ProtectedData only has allocating byte[] overloads, but in .NET 5+, Span overloads can avoid allocations.

Issue #109480 108734

Wrong issue link 🙂

ChadNedzlek and others added 9 commits November 5, 2024 13:08
@ChadNedzlek @bartonjs
Update src/libraries/System.Security.Cryptography.ProtectedData/src/S…
ca7e146 
…ystem/Security/Cryptography/ProtectedData.cs

Co-authored-by: Jeremy Barton <[email protected]>
@ChadNedzlek @bartonjs
Update src/libraries/System.Security.Cryptography.ProtectedData/src/S…
c63c74c 
…ystem/Security/Cryptography/ProtectedData.cs

Co-authored-by: Jeremy Barton <[email protected]>
@ChadNedzlek @bartonjs
Update src/libraries/System.Security.Cryptography.ProtectedData/src/S…
af6f8e6 
…ystem/Security/Cryptography/ProtectedData.cs

Co-authored-by: Jeremy Barton <[email protected]>
@ChadNedzlek @bartonjs
Update src/libraries/System.Security.Cryptography.ProtectedData/src/S…
21621d9 
…ystem/Security/Cryptography/ProtectedData.cs

Co-authored-by: Jeremy Barton <[email protected]>
@ChadNedzlek @bartonjs
Update src/libraries/System.Security.Cryptography.ProtectedData/tests…
f7a52ac 
…/SpanProtectedDataTests.cs

Co-authored-by: Jeremy Barton <[email protected]>
@ChadNedzlek @bartonjs
Update src/libraries/System.Security.Cryptography.ProtectedData/src/S…
aeb5c9b 
…ystem/Security/Cryptography/ProtectedData.cs

Co-authored-by: Jeremy Barton <[email protected]>
@ChadNedzlek @bartonjs
Update src/libraries/System.Security.Cryptography.ProtectedData/src/S…
582e132 
…ystem/Security/Cryptography/ProtectedData.cs

Co-authored-by: Jeremy Barton <[email protected]>
@ChadNedzlek @bartonjs
Update src/libraries/System.Security.Cryptography.ProtectedData/src/S…
25d3434 
…ystem/Security/Cryptography/ProtectedData.cs

Co-authored-by: Jeremy Barton <[email protected]>
@ChadNedzlek
Addressing review comments
bb0af2e
This was referenced Nov 8, 2024
Open
Open
@bartonjs bartonjs merged commit 2f24ac9 into dotnet:main Nov 8, 2024
80 of 83 checks passed
@bartonjs bartonjs added this to the 10.0.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcsjones vcsjones vcsjones left review comments

@bartonjs bartonjs bartonjs approved these changes

Assignees

@ChadNedzlek ChadNedzlek

Labels
area-System.Security new-api-needs-documentation
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Add Span<byte> support to System.Security.Cryptography.ProtectedData
4 participants
@ChadNedzlek @danzuep @vcsjones @bartonjs