Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][aot] Disable dedup for wrapper with a return type which has a … #80279

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Jan 6, 2023

…cmod.

The wrappers are not found at runtime in some cases.

Re: #79152.

…cmod.

The wrappers are not found at runtime in some cases.

Ref: dotnet#79814.
@vargaz
Copy link
Contributor Author

vargaz commented Jan 6, 2023

@jeromelaban this might fix:
unoplatform/uno#10763

@lewing
Copy link
Member

lewing commented Jan 6, 2023

waiting on #80282

@tannergooding
Copy link
Member

Should be unblocked now. Closing and reopening the PR should retrigger CI with the updated main.

@tannergooding tannergooding reopened this Jan 6, 2023
@vargaz vargaz merged commit b0601cf into dotnet:main Jan 6, 2023
@vargaz vargaz deleted the dedup-no-cmods branch January 6, 2023 05:32
@lewing
Copy link
Member

lewing commented Jan 22, 2023

Should we backport this to 7? I'm hesitant because dedup isn't really a supported scenario in net7.0 but uno allows it and it is a customer issue

@lewing
Copy link
Member

lewing commented Jan 22, 2023

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3980933613

@DierkDroth
Copy link

@lewing @vargaz thanks for working on that issue.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants