Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a build error around the ConstantExpected analyzer #80282

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

tannergooding
Copy link
Member

@tannergooding tannergooding commented Jan 6, 2023

This should resolve the error that was cropping up due to #80192

Fixes #80281 .

@ghost
Copy link

ghost commented Jan 6, 2023

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

This should resolve the error that was cropping up due to #80192

Author: tannergooding
Assignees: tannergooding
Labels:

area-System.Numerics

Milestone: -

@tannergooding
Copy link
Member Author

/azp run runtime-wasm-libtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tannergooding
Copy link
Member Author

Merging, all the builds are past the point of failure now and I was able to reproduce the failure and validate the fix locally.

Failure was due to a mismatch between CI and the PR that actually pulled in the analyzer

@tannergooding tannergooding merged commit 8ebfddb into dotnet:main Jan 6, 2023
@tannergooding tannergooding deleted the const-expected branch January 6, 2023 02:21
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants