[release/7.0] Fix special sweep issue for workstation #83342
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #81248 to release/7.0 /cc @cshung Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@cshung @mangod9 if the intention is to get this included in the April servicing release, please fill out the template describing the customer impact, and send an email to Tactics requesting approval. The CI finished green so we can get it merged quickly if that's what you desire. Code complete for April is today. Otherwise, we can wait for next month's release. |
|
I'm retargeting this PR to the new Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:
The new process is described here: runtime/docs/project/library-servicing.md. The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues. Let me know if you have any questions. |
carlossanlop
added
Servicing-approved
|
Reminder: April 10th is the last day to merge backport PRs to ensure they get included in the May Release. PR owners are now in charge of merging their own PRs. |
|
@cshung, this is ok to merge right? |
Yes, it is ready to be merged. The parent PR shows all the validations that we have done, and the CI failure here is a known fixed issue. |
|
Merged now. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #81248 to release/7.0
/cc @cshung
Customer Impact
This issue has been found during local testing while working on fixing #80073. This fix is required for #83341.
Bug condition: In the case of using workstation mode, low memory condition, we might not be able to obtain a region before GC happens. In that case, we have to run the special sweep mode. Without this fix, we may run the compact mode instead if the earlier heuristic decides compaction is a better choice.
Bug impact: After compaction, we will run out of available regions to build gen 0, which will eventually crash the process during the next allocation.
Testing
Validated with Stress locally and also in customer environment
Risk
Low, same logic exists for SVR, this moves it to WKS
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.