Platform_TimeZoneNames failing for Iran time zones on macOS #83901

jkoritzinsky · 2023-03-24T20:48:35Z

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=216592
Build error leg or test failing: System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames
Pull request: #83755

Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "(UTC+03:30) Iran Standard Time (Tehran)",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Report

Build	Definition	Test	Pull Request
220994	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83966
220990	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83965
220938	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames
220380	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83574
220952	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames
220943	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames
220848	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames
220781	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames
220128	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83565
220785	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames
220516	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83557
220473	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83829
220438	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83728
220447	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83965
220439	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83742
220422	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83958
220430	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83079
220426	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83966
220409	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83743
220414	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83813
220418	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83957
220399	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83729
220369	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83425
220389	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83577
220393	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83602
220365	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83342
220361	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83341
220373	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83462
220356	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83078
220348	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#80955
220352	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#81607
220329	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames
220338	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames
220334	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames
220333	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames
220214	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames
220145	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83302
220149	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83303
218383	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83966
219430	dotnet/runtime	System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames	#83577

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
38	40	40

jkoritzinsky · 2023-03-24T23:53:30Z

@hoyosjs Any ideas why this isn't catching the failures? The message is in the test failure:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=216592&view=ms.vss-test-web.build-test-results-tab&runId=4043580&paneView=debug&resultId=172087

jkoritzinsky · 2023-03-24T23:54:32Z

Looks like the text is in the specific subcase that failed. Maybe the Known Issues logic isn't searching in test subcases that failed?

Fixes dotnet#83901

ghost · 2023-03-25T10:54:49Z

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=216592
Build error leg or test failing: System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames
Pull request: #83755

Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "(UTC+03:30) Iran Standard Time (Tehran)",
  "BuildRetry": false,
  "ErrorPattern": "",
  "ExcludeConsoleLog": true
}

Report

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	0	0

Author:	jkoritzinsky
Assignees:	-
Labels:	`area-System.Globalization`, `disabled-test`, `untriaged`
Milestone:	-

Fixes dotnet#83901

tarekgh · 2023-03-25T19:52:24Z

[FAIL] System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames(tzi: (UTC+03:30) Iran Standard Time (Tehran), displayName: "(UTC+03:30) Iran Time", standardName: "Iran Standard Time", daylightName: "Iran Daylight Time")
Assert.Equal() Failure
                                 ↓ (pos 31)
Expected: ···: "(UTC+03:30) Iran Time", StandardName: Iran Standard Time",···
Actual:   ···: "(UTC+03:30) Iran Standard Time (Tehran)", StandardName: Ir···
                                 ↑ (pos 31)
   at System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames(TimeZoneInfo tzi, String displayName, String standardName, String daylightName) + 0x71c
   at System.Runtime!<BaseAddress>+0x11ef4a0
   at System.Reflection.DynamicInvokeInfo.Invoke(Object, IntPtr, Object[], BinderBundle, Boolean) + 0x14c
[SKIP] System.Reflection.Tests.ReflectionCacheTests.InvokeClearCache_NoExceptions
[SKIP] System.Reflection.Tests.ReflectionCacheTests.GetMembers_MultipleCalls_ClearCache_ReflectionCacheTestsType
[SKIP] System.Reflection.Tests.ReflectionCacheTests.GetMembers_MultipleCalls_ClearCache_All
Finished System.Runtime.Tests, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51

hoyosjs · 2023-03-27T18:20:20Z

Looks like the text is in the specific subcase that failed. Maybe the Known Issues logic isn't searching in test subcases that failed?

@dotnet/dnceng do you know why this blob isn't matching? It seems to fit and it appears in the error section of the test case.

chcosta · 2023-03-27T18:38:14Z

@hoyosjs, sorry it's not behaving as you expect. Understanding this will require some investigation. Can you file an issue in Arcade with sufficient context / repro so that it can be triaged and addressed appropriately?

carlossanlop · 2023-03-28T20:39:24Z

This is also happening in 6.0 and 7.0, so I'm reopening the issue.
Can we please backport the fix? Reminder to backport to release/6.0-staging and release/7.0-staging.

Affected 7.0 PR is: #83747
Affected 6.0 PR is: #83748

Failure message in both is:

    System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames(tzi: (UTC+03:30) Iran Standard Time (Tehran), displayName: "(UTC+03:30) Iran Time", standardName: "Iran Standard Time", daylightName: "Iran Daylight Time") [FAIL]
      Assert.Equal() Failure
                                       ↓ (pos 31)
      Expected: ···: "(UTC+03:30) Iran Time", StandardName: Iran Standard Time",···
      Actual:   ···: "(UTC+03:30) Iran Standard Time (Tehran)", StandardName: Ir···
                                       ↑ (pos 31)
      Stack Trace:
        /_/src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs(140,0): at System.Tests.TimeZoneInfoTests.Platform_TimeZoneNames(TimeZoneInfo tzi, String displayName, String standardName, String daylightName)
        /_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(370,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Clockwork-Muse · 2023-03-28T21:40:31Z

... so, why do we have tests that are dependent on external data with no guarantee of stability? Should we be just checking for a non-empty string? That it contains part of some content?

tarekgh · 2023-03-28T21:45:06Z

@Clockwork-Muse it is good to be aware of the changes and find out if the change make sense too.

carlossanlop · 2023-03-29T02:38:17Z

@hoyosjs Any ideas why this isn't catching the failures?

The json pattern is correct, but the Known Build Error label was missing. That label is what makes the bot start monitoring failures that match the json pattern.

I added the label a few hrs ago but it isn't matching the 7.0 and 6.0 patterns. I suspect it's because the ExcludeConsoleLog item was set to true. I changed it to false, hopefully that'll make the failures to get collected.

carlossanlop · 2023-03-29T03:17:02Z

I suspect it's because the ExcludeConsoleLog item was set to true. I changed it to false, hopefully that'll make the failures to get collected.

Yep, that was it. The bot is collecting failed CI legs now.

carlossanlop · 2023-03-29T17:18:52Z

Backports merged. We can close this.

jkoritzinsky added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Mar 24, 2023

dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 24, 2023

ghost added the untriaged New issue has not been triaged by the area owner label Mar 24, 2023

jkotas added a commit to jkotas/runtime that referenced this issue Mar 25, 2023

Comment out Iran timezone tests

011955a

Fixes dotnet#83901

jkotas mentioned this issue Mar 25, 2023

Comment out Iran timezone tests #83916

Merged

ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Mar 25, 2023

stephentoub added disabled-test The test is disabled in source code against the issue and removed blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Mar 25, 2023

stephentoub closed this as completed in 3a82439 Mar 25, 2023

ghost removed the untriaged New issue has not been triaged by the area owner label Mar 25, 2023

stephentoub reopened this Mar 25, 2023

ghost added the untriaged New issue has not been triaged by the area owner label Mar 25, 2023

stephentoub added area-System.Globalization and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners untriaged New issue has not been triaged by the area owner labels Mar 25, 2023

stephentoub added the untriaged New issue has not been triaged by the area owner label Mar 25, 2023

UnityAlex pushed a commit to Unity-Technologies/runtime that referenced this issue Mar 25, 2023

Comment out Iran timezone tests (dotnet#83916)

8165434

Fixes dotnet#83901

tarekgh added area-System.DateTime and removed area-System.Globalization labels Mar 25, 2023

tarekgh added this to the Future milestone Mar 25, 2023

ghost removed the untriaged New issue has not been triaged by the area owner label Mar 25, 2023

tarekgh self-assigned this Mar 25, 2023

tarekgh mentioned this issue Mar 26, 2023

Fix Iran time zone test case #83952

Merged

tarekgh closed this as completed Mar 27, 2023

StephenMolloy mentioned this issue Mar 27, 2023

Modernize XmlUTF8TextWriter with u8/inline out's. #75812

Merged

janvorli mentioned this issue Mar 27, 2023

[release/7.0] Fix reserving executable memory as per allocation type in ClrVirtualAllocWithinRange() #83958

Merged

simonrozsival mentioned this issue Mar 28, 2023

[release/7.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589) #83966

Merged

carlossanlop reopened this Mar 28, 2023

This was referenced Mar 28, 2023

[6.0] Avoid using spanish helix queues #83748

Merged

[7.0] Avoid using spanish helix queues #83747

Merged

carlossanlop added the Known Build Error Use this to report build issues in the .NET Helix tab label Mar 28, 2023

carlossanlop added Known Build Error Use this to report build issues in the .NET Helix tab and removed Known Build Error Use this to report build issues in the .NET Helix tab labels Mar 29, 2023

carlossanlop mentioned this issue Mar 29, 2023

[7.0] Fix Iran time zone test case #84056

Merged

ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 29, 2023

carlossanlop mentioned this issue Mar 29, 2023

[6.0] Fix Iran time zone test case #84057

Merged

This was referenced Mar 29, 2023

[release/6.0] Bump to new OSX 13 AppleTV queue #83728

Merged

[release/7.0] Improve servicing docs for Microsoft.Windows.Compatibility #83557

Merged

rzikm mentioned this issue Mar 29, 2023

[release/7.0] Ensure free buffer space when reading TLS messages #83574

Merged

simonrozsival mentioned this issue Mar 29, 2023

[release/6.0] Use CLOCK_BOOTTIME to calculate BootTime on linux (#67589) #83965

Merged

ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 29, 2023

carlossanlop closed this as completed Mar 29, 2023

This was referenced Apr 5, 2023

Update branding to 6.0.17 #84315

Merged

[release/7.0] Reverting: Set AssemblyName.ProcessorArchitecture for compatibility (#81101) #83565

Merged

ghost locked as resolved and limited conversation to collaborators Apr 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Platform_TimeZoneNames failing for Iran time zones on macOS #83901

Platform_TimeZoneNames failing for Iran time zones on macOS #83901

jkoritzinsky commented Mar 24, 2023 •

edited by build-analysis bot

Loading

jkoritzinsky commented Mar 24, 2023

jkoritzinsky commented Mar 24, 2023

ghost commented Mar 25, 2023

Build Information

Error Message

Report

Summary

tarekgh commented Mar 25, 2023

hoyosjs commented Mar 27, 2023

chcosta commented Mar 27, 2023

carlossanlop commented Mar 28, 2023 •

edited

Loading

Clockwork-Muse commented Mar 28, 2023

tarekgh commented Mar 28, 2023

carlossanlop commented Mar 29, 2023

carlossanlop commented Mar 29, 2023

carlossanlop commented Mar 29, 2023

Platform_TimeZoneNames failing for Iran time zones on macOS #83901

Platform_TimeZoneNames failing for Iran time zones on macOS #83901

Comments

jkoritzinsky commented Mar 24, 2023 • edited by build-analysis bot Loading

Build Information

Error Message

Report

Summary

jkoritzinsky commented Mar 24, 2023

jkoritzinsky commented Mar 24, 2023

ghost commented Mar 25, 2023

Build Information

Error Message

Report

Summary

tarekgh commented Mar 25, 2023

hoyosjs commented Mar 27, 2023

chcosta commented Mar 27, 2023

carlossanlop commented Mar 28, 2023 • edited Loading

Clockwork-Muse commented Mar 28, 2023

tarekgh commented Mar 28, 2023

carlossanlop commented Mar 29, 2023

carlossanlop commented Mar 29, 2023

carlossanlop commented Mar 29, 2023

jkoritzinsky commented Mar 24, 2023 •

edited by build-analysis bot

Loading

carlossanlop commented Mar 28, 2023 •

edited

Loading