-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0] disable NTLM tests on RedHat.7 #83602
[release/7.0] disable NTLM tests on RedHat.7 #83602
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #83559 to release/7.0 /cc @wfurt Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
@@ -86,6 +87,10 @@ public void Package_Supported_NTLM() | |||
[ConditionalFact(nameof(IsNtlmUnavailable))] | |||
public void Package_Unsupported_NTLM() | |||
{ | |||
if (PlatformDetection.IsRedHatFamily7) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it possible to add conditions to the KnownIssue
attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another attribute to skip tests in certain platforms or architectures. Anyway, not blocking.
I'm retargeting this PR to the new Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:
The new process is described here: runtime/docs/project/library-servicing.md. The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues. Let me know if you have any questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test-only change. Approving.
Backport of #83559 to release/7.0
test only change to stabilize CI
Customer Impact
Testing
Risk
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.