Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] SyntaxValueProvider: avoid performance issue with syntax list containing many items #83742

Merged
merged 5 commits into from
Apr 4, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 21, 2023

Backport of #83483 to release/6.0

/cc @ericstj @cston

Customer Impact

Original issue: dotnet/roslyn#66475
When a source file contains a large array, performance of compilation degraded substantially (customer case was 50x observed build perf). This bug will appear as a regression from GA since this was introduced in the servicing change #72219.

Testing

Test added to cover this scenario.
Tested repro from dotnet/roslyn#66475 (comment).

Risk

Low. This just adds an additional forward iteration.

  • Package Authoring

@ghost
Copy link

ghost commented Mar 21, 2023

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #83483 to release/6.0

/cc @ericstj @cston

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Extensions-Logging

Milestone: -

@ericstj
Copy link
Member

ericstj commented Mar 21, 2023

Needs package changes for JSON and Logging

@ericstj ericstj added the Servicing-consider Issue for next servicing release review label Mar 28, 2023
@rbhanda rbhanda added this to the 6.0.17 milestone Mar 28, 2023
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 28, 2023
@carlossanlop
Copy link
Member

I'm retargeting this PR to the new release/6.0-staging branch, which is the one that we will use from now on for servicing fixes.

Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:

  • It is approved by Tactics (signaled by adding the Servicing-approved label).
  • It's signed-off by an area owner.
  • The CI is green, or the failures are investigated as unrelated.
  • And if the PR touches an OOB package, the necessary OOB authoring changes are added.

The new process is described here: runtime/docs/project/library-servicing.md.

The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues.

Let me know if you have any questions.

@carlossanlop carlossanlop changed the base branch from release/6.0 to release/6.0-staging March 28, 2023 21:07
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-approved Approved for servicing release labels Mar 30, 2023
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOB changes look good.

@tarekgh @cston not sure if you saw but the new check-service-labels CI leg was stuck because there were some weird problems with GitHub Actions yesterday. The fix is to remove and readd the Servicing-approved label, and the check will get retriggered (and should pass). I did that, and you are now allowed to merge if the CI results look good to you.

@tarekgh
Copy link
Member

tarekgh commented Apr 3, 2023

@ericstj any more feedback or we can merge this PR?

@ericstj
Copy link
Member

ericstj commented Apr 4, 2023

Nope, no feedback from me - just make sure CI looks good and merge

@tarekgh
Copy link
Member

tarekgh commented Apr 4, 2023

CI failures are not related and already tracked/fixed. merging this.

@tarekgh tarekgh merged commit 2b36dbe into release/6.0-staging Apr 4, 2023
@tarekgh tarekgh deleted the backport/pr-83483-to-release/6.0 branch April 4, 2023 19:36
@ghost ghost locked as resolved and limited conversation to collaborators May 5, 2023
@leecow leecow modified the milestones: 6.0.17, 6.0.18 Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Logging Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants