Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NuGet-Migrations workaround to runtime tests too #84129

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Add NuGet-Migrations workaround to runtime tests too #84129

merged 3 commits into from
Apr 11, 2023

Conversation

akoeplinger
Copy link
Member

See #80619

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 30, 2023
@ghost ghost assigned akoeplinger Mar 30, 2023
This was referenced Mar 30, 2023
Closed
Closed
Closed
@steveisok
Copy link
Member

@akoeplinger it appears your change didn't apply to part of WasmBuildTests. BuildPublishTests.DefaultTemplate_WithoutWorkload failed with the NuGet-Migrations error.

@steveisok steveisok requested review from lewing and steveisok April 3, 2023 16:20
@lewing
Copy link
Member

lewing commented Apr 11, 2023

what is the status here? tests are still failing

@jeffhandley jeffhandley added area-Infrastructure-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 11, 2023
@ghost
Copy link

ghost commented Apr 11, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

See #80619

Author: akoeplinger
Assignees: akoeplinger
Labels:

area-Infrastructure-mono
Milestone: -

@steveisok
Copy link
Member

what is the status here? tests are still failing

Still trying a workaround for wbt. We could take this PR and deal with that part separately.

@runfoapp runfoapp bot mentioned this pull request Apr 11, 2023
Closed
@steveisok steveisok marked this pull request as ready for review April 11, 2023 22:46
@steveisok steveisok merged commit 986bd09 into dotnet:main Apr 11, 2023
@steveisok steveisok deleted the workaround-nuget branch April 11, 2023 22:53
This was referenced Apr 11, 2023
Open
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveisok steveisok steveisok approved these changes

@lewing lewing Awaiting requested review from lewing

Assignees

@akoeplinger akoeplinger

Labels
area-Infrastructure-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akoeplinger @steveisok @lewing @jeffhandley