Bump Microsoft.Private.Intellisense package version

[carlossanlop]

Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706

This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.

Will backport.

[ghost]

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Generated it via the dotnet-api-docs pipeline: https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=382697&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=11e7ea89-affe-5194-cdc6-0171c3394706

This is not the latest version of the package but adds docs for more than half of the APIs added in .NET 8.

Will backport.

Author:	carlossanlop
Assignees:	carlossanlop
Labels:	documentation, area-Infrastructure-libraries
Milestone:	-

[ViktorHofer]

Approving but CI is failing

[carlossanlop]

The problem was that we're still pushing to dotnet7-transport. I manually pushed the private package to the dotnet8-transport.
Closing and reopening to trigger the CI again.

[ViktorHofer]

Now source build tells you that you are introducing a new prebuilt. You need to add the package to https://github.com/dotnet/source-build-reference-packages. cc @mthalman @MichaelSimons

EDIT:
You can do that via the following command: generate.cmd/sh -p Microsoft.Private.Intellisense,8.0.0-preview-20230828.1 -t text

[mthalman]

Be aware of this: #77004

[carlossanlop]

Thanks @ViktorHofer for the instructions, and thanks @mthalman @MichaelSimons for the warning (#77004).

I want to reduce the burden of having to manually add a new package version to source-build-reference-packages. So I would like to do this update process only two times:

1. I'd like to merge this PR (after merging the other repo's PR Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230828.1 source-build-reference-packages#774)) to make sure everything works as expected and nothing breaks.
2. I'll submit only one more PR doing this same process, with the final package with docs for .NET 8.

Does this sound good to everyone?

[carlossanlop]

I would also like to learn how to automate this, or completely get rid of the necessity of manually updating the package in source-build-reference-packages, but I don't know what's needed to achieve this. Who can guide me through this?

[ViktorHofer]

but I don't know what's needed to achieve this. Who can guide me through this?

One thing: make the XML documentation files source of truth the repositories themselves. As long as we rely on an external repository supplying a nuget package with the documentation XML files, we will always have prebuilds.

[carlossanlop]

We merged dotnet/source-build-reference-packages#774 so it should be safe to merge this now.

[carlossanlop]

/backport to release/8.0

[github-actions]

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6054208982

[ViktorHofer]

We merged dotnet/source-build-reference-packages#774 so it should be safe to merge this now.

No. This nukes the build. You need to wait for a dependency update from source-build-reference-packages into runtime. Please never merge a PR in with a failing source build leg. I will take care of fixing the build.