-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230828.1 #774
Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230828.1 #774
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since runtime is the only repo referencing this package that participates in source-build, the old version can be deleted.
Also, as stated in the workflow, the new project should be added to Build.props.
It's not just runtime. At least winforms uses that package as well. But they should also upgrade to the new version as part of this. Therefore deleting the old version makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider deleting the old version
@mthalman @ViktorHofer can I delete the old version in a separate PR? I first need to ensure that the other repos that consume the package have already upgraded to 20230828.1, otherwise we would end up with the same problem we're trying to fix, I am assuming. |
I created dotnet/source-build#3611 to track the deletion request and assigned it to myself, so that we can unblock this PR. @mthalman would you mind merging this? |
Even without deleting the old version, this can't be merged until Build.props file is updated. |
Package 7.0.0-preview-20221010.1 is consumed by .NET 7.0. Would it cause source-build problems in that .NET version if I delete that folder? |
No. SBRP is only used for .NET 8+. |
Ok thanks for confirming. I deleted the old code and also added the missing item in Build.props. |
As suggested in this comment: dotnet/runtime#91285 (comment) I ran:
This is the workaround for dotnet/runtime#77004
@ViktorHofer @mthalman @MichaelSimons please review to unblock dotnet/runtime#91285