-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dotnet new sln --format slnx
#44469
Conversation
4d09f12
to
6912ee4
Compare
@baronfel ptal. i don't know why the ci is not starting here. i tried closing reopening and pushing changes but no luck |
@kasperk81 my best guess is that resources are slammed right now preparing for .NET 9 GA? I'll kick them and see if that helps. |
/azp run dotnet-sdk-public-ci,sdk-source-build, sdk-unified-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content here seems fine - though without dotnet sln add
and dotnet sln remove
users won't be able to really do anything useful with the slnx yet. That's fine, I just wanted to call it out for now.
Thank you for taking an interest in this @kasperk81!
Thanks @baronfel! This PR ( |
/azp run |
saw same issue in #44481. it seems to be randomly filtering out some PRs and running for others |
Will |
Yes, but that will require coordination with the VS solution team around when they want to make the format 'stable' and default to it in VS. Having that decision require just a very small boolean default value change in the template here is a smart move by @kasperk81 to make the cost of updating the SDK to match VS very light. |
@surayya-MS, @rainersigwald, do you and your team have any suggestions (drawing on your experience with MSBuild) for implementing the
Would you or someone from your team be interested in helping with the initial replacement or providing input? Any insights from the MSBuild transition would be especially helpful. Thank you! 😊 |
There's an infrastructure issue in AzDo that's being worked on right now. Will bump this as I know more. |
This LGTM, but I'm waiting for feedback from the VS Solution team about what they would like to call the two options for sln/slnx formats. |
Ok I have feedback from the VS team on their desired terminology for the sln/slnx choice help text. @kasperk81 please use the phrases "Solution file" and "XML Solution file" instead of "Traditional solution file" and "XML-based solution file". Other than that change this is good to go! |
Thanks for this @kasperk81! |
/backport to release/9.0.2xx |
Started backporting to release/9.0.2xx: https://github.com/dotnet/sdk/actions/runs/11602176374 |
default (without --format) is
.sln
.Contributes to #40913