Fix .NET Framework test helix submission #44481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
akoeplinger
approved these changes
Oct 28, 2024
|
/azp run |
1 similar comment
|
/azp run |
MiYanni
approved these changes
Oct 28, 2024
test/UnitTests.proj
Outdated
Comment on lines
31
to
43
| <SDKCustomXUnitProject Include=" | ||
| core-sdk-tasks.Tests\core-sdk-tasks.Tests.csproj; | ||
| Microsoft.DotNet.ApiCompat.IntegrationTests\Microsoft.DotNet.ApiCompat.IntegrationTests.csproj | ||
| Microsoft.DotNet.ApiCompat.Tests\Microsoft.DotNet.ApiCompat.Tests.csproj; | ||
| Microsoft.DotNet.ApiCompatibility.Tests\Microsoft.DotNet.ApiCompatibility.Tests.csproj; | ||
| Microsoft.DotNet.ApiSymbolExtensions.Tests\Microsoft.DotNet.ApiSymbolExtensions.Tests.csproj; | ||
| Microsoft.DotNet.MSBuildSdkResolver.Tests\Microsoft.DotNet.MSBuildSdkResolver.Tests.csproj; | ||
| Microsoft.DotNet.PackageValidation.Tests\Microsoft.DotNet.PackageValidation.Tests.csproj; | ||
| Microsoft.DotNet.TemplateLocator.Tests\Microsoft.DotNet.TemplateLocator.Tests.csproj; | ||
| Microsoft.NET.Build.Containers.IntegrationTests\Microsoft.NET.Build.Containers.IntegrationTests.csproj; | ||
| Microsoft.NET.Sdk.Publish.Tasks.Tests\Microsoft.NET.Sdk.Publish.Tasks.Tests.csproj; | ||
| Microsoft.NET.Sdk.WorkloadManifestReader.Tests\Microsoft.NET.Sdk.WorkloadManifestReader.Tests.csproj; | ||
| Microsoft.Win32.Msi.Tests\Microsoft.Win32.Msi.Tests.csproj" |
There was a problem hiding this comment.
Is this the only way to know which unit test projects apply to net472? A hardcoded list? Hmm. Just wish there was something a little cleaner and less brittle.
There was a problem hiding this comment.
Definitely not the only way. We don't have a hardcoded list in other repos but other repos don't really use the XUnitProject Arcade Helix SDK integration. This is already the status quo in main so I'm not going to change that in this PR. Filed #44490.
|
/azp run dotnet-sdk-public-ci,sdk-source-build,sdk-unified-build |
1 similar comment
|
/azp run dotnet-sdk-public-ci,sdk-source-build,sdk-unified-build |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to AzDO and a binlog from the NETFULLFRAMEWORK leg, .NET Framework tests don't run.
The
_AGENTOSNAMEproperty / env var doesn't exist anymore. This regressed between 9.0 P4 and P5: https://github.com/dotnet/sdk/blame/eaecfdeddb3e4c87f34a075e7b6892d0eab2a343/eng/build.yml#L47-L48Changes
_AGENTOSNAMEproperty with theTestFullMSBuildproperty.Don't run .NETCoreApp tests in the NETFULLFRAMEWORK leg.I realized that they intentionally run as they are exercised with desktop msbuild which provides some usefulness.