-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hiddenWhen to debuggers in package.json #6405
Conversation
This PR adds the 'hiddenWhen' attribute to debuggers contributed by the C# Extension.
I assume the plan here is to wait for a 1.83 version of vscode to be released? |
Do we have a pre-release train this could hop on for validation? |
We don't currently have a planned prerelease, but we can ship a prerelease out of main at any time. That prerelease would only work on vscode insiders though. The other, more complicated problem is that our integration tests run on vscode release. We would also have to switch the integration tests to acquire and run on insiders vscode in order to merge this PR (they're currently all failing on this PR for that reason) |
Do we need to wait? In other words, will older versions of VS Code just ignore the attribute? (assume the change on line 875 isn't required) |
These changes work if you use a version of vscode >1.83.0. We do not need the engine upgrade requirement. |
This PR adds the 'hiddenWhen' attribute to debuggers contributed by the C# Extension.
Related: microsoft/vscode#193157
Fixes:
Note: This PR requires the VS Code September 2023 Update