Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hiddenWhen to debuggers in package.json #6405

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Conversation

WardenGnaw
Copy link
Contributor

This PR adds the 'hiddenWhen' attribute to debuggers contributed by the
C# Extension.
@WardenGnaw WardenGnaw requested a review from a team as a code owner September 20, 2023 18:39
@WardenGnaw WardenGnaw self-assigned this Sep 20, 2023
@dibarbet
Copy link
Member

I assume the plan here is to wait for a 1.83 version of vscode to be released?

@timheuer
Copy link
Member

I assume the plan here is to wait for a 1.83 version of vscode to be released?

Do we have a pre-release train this could hop on for validation?

@dibarbet
Copy link
Member

I assume the plan here is to wait for a 1.83 version of vscode to be released?

Do we have a pre-release train this could hop on for validation?

We don't currently have a planned prerelease, but we can ship a prerelease out of main at any time. That prerelease would only work on vscode insiders though.

The other, more complicated problem is that our integration tests run on vscode release. We would also have to switch the integration tests to acquire and run on insiders vscode in order to merge this PR (they're currently all failing on this PR for that reason)

@gregg-miskelly
Copy link
Contributor

gregg-miskelly commented Sep 21, 2023

Do we need to wait? In other words, will older versions of VS Code just ignore the attribute? (assume the change on line 875 isn't required)

@WardenGnaw
Copy link
Contributor Author

These changes work if you use a version of vscode >1.83.0. We do not need the engine upgrade requirement.

package-lock.json Outdated Show resolved Hide resolved
@WardenGnaw WardenGnaw merged commit 5483987 into main Sep 21, 2023
8 checks passed
@WardenGnaw WardenGnaw deleted the dev/waan/addHiddenWhen branch September 21, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants