Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to de-emphasize debuggers in run list #193157

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

WardenGnaw
Copy link
Member

@WardenGnaw WardenGnaw commented Sep 15, 2023

This PR supports hiding debuggers in VS Code similar to the when clause, but when will disable the debugger from being used, but the new field hiddenWhen will allow the debugger to still be used. If hiddenWhen is evaluated to be true, it will hide the debuggers in the list.

Example usage in package.json to hide the debugger selection if the C# Dev Kit is installed.

    "type": "coreclr",
    "hiddenWhen ": "dotnet.debug.serviceBrokerAvailable",
    "label": ".NET 5+ and .NET Core",

Before:
image

After:
image

Fixes: #184457

This PR supports hiding debuggers in VS Code similar to the when clause.
If this field is set to true, it will hide the debuggers in the list.
@gjsjohnmurray
Copy link
Contributor

I find the name hard to understand. Did you consider alternatives such as hiddenWhen?

@WardenGnaw
Copy link
Member Author

I find the name hard to understand. Did you consider alternatives such as hiddenWhen?

I agree hiddenWhen captures the intent of this. I'll switch it to that.

@vscodenpa vscodenpa added this to the September 2023 milestone Sep 18, 2023
@roblourens roblourens merged commit 347abe1 into microsoft:main Sep 18, 2023
5 checks passed
@WardenGnaw WardenGnaw deleted the dev/waan/deemphasizeDebuggers branch September 19, 2023 19:44
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deemphasise an initial configuration provider if an extension is installed.
5 participants