fix(vscode): Add dotnet executable path in list runtimes command #6559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
reviewed
Oct 17, 2023
| @@ -70,7 +70,8 @@ async function parseDotnetInfo(dotnetInfo: string, dotnetExecutablePath: string | |||
| } | |||
|
|
|||
| const runtimeVersions: { [runtime: string]: RuntimeInfo[] } = {}; | |||
| const listRuntimes = await execChildProcess('dotnet --list-runtimes', process.cwd(), process.env); | |||
| const command = dotnetExecutablePath ? `"${dotnetExecutablePath}"` : 'dotnet'; | |||
| const listRuntimes = await execChildProcess(`${command} --list-runtimes`, process.cwd(), process.env); | |||
There was a problem hiding this comment.
This is most likely all correct, but give me a bit to pull this down locally and run it through an extra gamut of tests. Changes here are always a bit dangerous.
There was a problem hiding this comment.
Thanks @dibarbet, I totally understand it and really appreciate it.
dibarbet
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Code Changes
dotnetExecutablePathto the list runtimes command the same way it does to info command