Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vscode): Add dotnet executable path in list runtimes command #6559

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix(vscode): Add dotnet executable path in list runtimes command #6559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/shared/utils/getDotnetInfo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ async function parseDotnetInfo(dotnetInfo: string, dotnetExecutablePath: string
}

const runtimeVersions: { [runtime: string]: RuntimeInfo[] } = {};
const listRuntimes = await execChildProcess('dotnet --list-runtimes', process.cwd(), process.env);
const command = dotnetExecutablePath ? `"${dotnetExecutablePath}"` : 'dotnet';
const listRuntimes = await execChildProcess(`${command} --list-runtimes`, process.cwd(), process.env);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is most likely all correct, but give me a bit to pull this down locally and run it through an extra gamut of tests. Changes here are always a bit dangerous.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dibarbet, I totally understand it and really appreciate it.

lines = listRuntimes.split(/\r?\n/);
for (const line of lines) {
let match: RegExpMatchArray | null;
Expand Down