Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix description of debugger console setting #6726

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

gregg-miskelly
Copy link
Contributor

@gregg-miskelly gregg-miskelly commented Dec 7, 2023

This PR updates the description of the console debugger setting. Improvements made:

  • The launch.json setting is applicable to all project types, so don't indicate it only applies to console projects
  • Update wording to match what we have in the documentation
  • Add a link to the documentation
  • Don't incorrectly indicate that internalConsole doesn't support reading from the console.

This PR also increases the max VSIX size to get PR builds working again. A node upgrade (18.18.2 -> 18.19.0) seems to have pushed us over the limit.

Here is what the new description looks like in the settings editor:
settings

And what it looks like when editing launch.json:
launch-json

@gregg-miskelly gregg-miskelly merged commit 5acd3f7 into dotnet:main Dec 8, 2023
13 checks passed
@gregg-miskelly gregg-miskelly deleted the FixConsoleDescription branch December 8, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants