feat(actions): add clear items action #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 277 278 +1
Branches 65 65
=====================================
+ Hits 277 278 +1
Continue to review full report at Codecov.
|
kentcdodds
approved these changes
Sep 12, 2017
README.md
Outdated
| @@ -452,6 +452,7 @@ These are functions you can call to change the state of the downshift component. | |||
| | property | type | description | | |||
| |-------------------------|------------------------------------------------------------------|------------------------------------------------------------------------------| | |||
| | `clearSelection` | `function(cb: Function)` | clears the selection | | |||
| | `clearItems` | `function()` | clears the items | | |||
There was a problem hiding this comment.
Could the description be more helpful:
Clears downshift's record of all the items. Only really useful if you render your items asynchronously within downshift. See [#186](https://github.com/paypal/downshift/issues/186)
| @@ -1,89 +1,112 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
I guess kcd-scripts is working 😅
We're now applying prettier to ts files! 🎉
|
Yeah, I think the TS definition for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Solves #186
Why:
No way to clear tracked items from children.
How:
Added
clearItemsas property method which setsthis.items = []Checklist: