-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(actions): add clear items action #187
Merged
kentcdodds
merged 2 commits into
downshift-js:master
from
ferdinandsalis:feature-clear-items
Sep 12, 2017
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,89 +1,112 @@ | ||
import * as React from 'react'; | ||
import * as React from 'react' | ||
|
||
export interface DownshiftProps { | ||
children: ChildrenFunction; | ||
defaultHighlightedIndex?: number | null; | ||
defaultSelectedItem?: any; | ||
defaultInputValue?: string; | ||
defaultIsOpen?: boolean; | ||
getA11yStatusMessage?: (options: A11yStatusMessageOptions) => any; | ||
itemToString?: (item: any) => string; | ||
onChange?: (selectedItem: any, stateAndHelpers: ControllerStateAndHelpers) => void; | ||
onStateChange?: (options: StateChangeOptions, stateAndHelpers: ControllerStateAndHelpers) => void; | ||
onUserAction?: (options: StateChangeOptions, stateAndHelpers: ControllerStateAndHelpers) => void; | ||
itemCount?: number; | ||
selectedItem?: any; | ||
isOpen?: boolean; | ||
inputValue?: string; | ||
highlightedIndex?: number; | ||
children: ChildrenFunction | ||
defaultHighlightedIndex?: number | null | ||
defaultSelectedItem?: any | ||
defaultInputValue?: string | ||
defaultIsOpen?: boolean | ||
getA11yStatusMessage?: (options: A11yStatusMessageOptions) => any | ||
itemToString?: (item: any) => string | ||
onChange?: ( | ||
selectedItem: any, | ||
stateAndHelpers: ControllerStateAndHelpers, | ||
) => void | ||
onStateChange?: ( | ||
options: StateChangeOptions, | ||
stateAndHelpers: ControllerStateAndHelpers, | ||
) => void | ||
onUserAction?: ( | ||
options: StateChangeOptions, | ||
stateAndHelpers: ControllerStateAndHelpers, | ||
) => void | ||
itemCount?: number | ||
selectedItem?: any | ||
isOpen?: boolean | ||
inputValue?: string | ||
highlightedIndex?: number | ||
} | ||
|
||
export interface A11yStatusMessageOptions { | ||
highlightedIndex: number | null; | ||
highlightedValue: any; | ||
inputValue: string; | ||
isOpen: boolean; | ||
itemToString: (item: any) => string; | ||
previousResultCount: number; | ||
resultCount: number; | ||
selectedItem: any; | ||
highlightedIndex: number | null | ||
highlightedValue: any | ||
inputValue: string | ||
isOpen: boolean | ||
itemToString: (item: any) => string | ||
previousResultCount: number | ||
resultCount: number | ||
selectedItem: any | ||
} | ||
|
||
export interface StateChangeOptions { | ||
highlightedIndex: number; | ||
inputValue: string; | ||
isOpen: boolean; | ||
selectedItem: any; | ||
highlightedIndex: number | ||
inputValue: string | ||
isOpen: boolean | ||
selectedItem: any | ||
} | ||
|
||
export interface GetRootPropsOptions { | ||
refKey: string; | ||
refKey: string | ||
} | ||
|
||
export interface GetInputPropsOptions extends React.HTMLProps<HTMLInputElement> { } | ||
export interface GetInputPropsOptions | ||
extends React.HTMLProps<HTMLInputElement> {} | ||
|
||
export interface GetLabelPropsOptions extends React.HTMLProps<HTMLLabelElement> { } | ||
export interface GetLabelPropsOptions | ||
extends React.HTMLProps<HTMLLabelElement> {} | ||
|
||
export interface GetButtonPropsOptions extends React.HTMLProps<HTMLButtonElement> { } | ||
export interface GetButtonPropsOptions | ||
extends React.HTMLProps<HTMLButtonElement> {} | ||
|
||
interface OptionalExtraGetItemPropsOptions { | ||
[key: string]: any; | ||
[key: string]: any | ||
} | ||
|
||
export interface GetItemPropsOptions extends OptionalExtraGetItemPropsOptions { | ||
index?: number; | ||
item: any; | ||
index?: number | ||
item: any | ||
} | ||
|
||
export interface ControllerStateAndHelpers { | ||
// prop getters | ||
getRootProps: (options: GetRootPropsOptions) => any; | ||
getButtonProps: (options?: GetButtonPropsOptions) => any; | ||
getLabelProps: (options?: GetLabelPropsOptions) => any; | ||
getInputProps: (options?: GetInputPropsOptions) => any; | ||
getItemProps: (options: GetItemPropsOptions) => any; | ||
// prop getters | ||
getRootProps: (options: GetRootPropsOptions) => any | ||
getButtonProps: (options?: GetButtonPropsOptions) => any | ||
getLabelProps: (options?: GetLabelPropsOptions) => any | ||
getInputProps: (options?: GetInputPropsOptions) => any | ||
getItemProps: (options: GetItemPropsOptions) => any | ||
|
||
// actions | ||
openMenu: (cb?: Function) => void; | ||
closeMenu: (cb?: Function) => void; | ||
toggleMenu: (cb?: Function) => void; | ||
selectItem: (item: any, otherStateToSet?: object, cb?: Function) => void; | ||
selectItemAtIndex: (index: number, otherStateToSet?: object, cb?: Function) => void; | ||
selectHighlightedItem: (otherStateToSet?: object, cb?: Function) => void; | ||
setHighlightedIndex: (index: number, otherStateToSet?: object, cb?: Function) => void; | ||
clearSelection: (cb?: Function) => void; | ||
reset: (otherStateToSet?: object, cb?: Function) => void; | ||
itemToString: (item: any) => void; | ||
// actions | ||
openMenu: (cb?: Function) => void | ||
closeMenu: (cb?: Function) => void | ||
toggleMenu: (cb?: Function) => void | ||
selectItem: (item: any, otherStateToSet?: object, cb?: Function) => void | ||
selectItemAtIndex: ( | ||
index: number, | ||
otherStateToSet?: object, | ||
cb?: Function, | ||
) => void | ||
selectHighlightedItem: (otherStateToSet?: object, cb?: Function) => void | ||
setHighlightedIndex: ( | ||
index: number, | ||
otherStateToSet?: object, | ||
cb?: Function, | ||
) => void | ||
clearSelection: (cb?: Function) => void | ||
clearItems: () => void | ||
reset: (otherStateToSet?: object, cb?: Function) => void | ||
itemToString: (item: any) => void | ||
|
||
// state | ||
highlightedIndex: number | null; | ||
inputValue: string | null; | ||
isOpen: boolean; | ||
selectedItem: any; | ||
// state | ||
highlightedIndex: number | null | ||
inputValue: string | null | ||
isOpen: boolean | ||
selectedItem: any | ||
} | ||
|
||
export type ChildrenFunction = (options: ControllerStateAndHelpers) => React.ReactNode; | ||
export type DownshiftInterface = React.ComponentClass<DownshiftProps>; | ||
export type ChildrenFunction = ( | ||
options: ControllerStateAndHelpers, | ||
) => React.ReactNode | ||
export type DownshiftInterface = React.ComponentClass<DownshiftProps> | ||
|
||
declare const Downshift: DownshiftInterface; | ||
export default Downshift; | ||
declare const Downshift: DownshiftInterface | ||
export default Downshift |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess
kcd-scripts
is working 😅We're now applying prettier to
ts
files! 🎉