chore: Add sideEffects hint for ESM bundlers.
#843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free.
What: This PR adds the
sideEffectshint topackage.json. This assumes thatDownshiftdoes not introduce any side effects.Why: So that bundlers can tree shake the ESM distribution of
Downshiftmore efficientlyHow: A simple boolean flag was added in
package.json.Checklist:
I am only assuming
Downshifthas no side effects. We should verify that before merging this.