fix: treeshake Downshift and useSelect #850
Conversation
| const validatePropTypes = | ||
| process.env.NODE_ENV === 'production' | ||
| ? noop | ||
| : getPropTypesValidator(useSelect, propTypes) |
There was a problem hiding this comment.
I rather recommend to use a condition in useSelect as in this case validatePropTypes function will be unused and removed:
if (process.env.NODE_ENV !== 'production') {
validatePropTypes(userProps)
}
silviuaavram
force-pushed
the
chore/treeshake-downshift
branch
from
5107ea7 to
b8ed39f
Compare
|
@all-contributors please add @layershifter with code, infra, ideas |
|
@silviuavram I've put up a pull request to add @layershifter! 🎉 |
|
@all-contributors please add @epiqueras with ideas |
|
@silviuavram I've put up a pull request to add @epiqueras! 🎉 |
silviuaavram
changed the title
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 8 -1
Lines 724 702 -22
Branches 156 158 +2
=====================================
- Hits 724 702 -22
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.4.8 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
defaultPropsandstateChangeTypesprevent Downshift from being tree-shakeable. Also the prop type checks inuseSelect.Use
no-side-effect-class-propertiesin.babelrc.jsalong with the original configs fromkcd-scripts. https://github.com/naver/babel-plugin-no-side-effect-class-properties @kentcdodds maybe you want to include this as well or mark it to be added once a more official version is released.Updated
rollup.config.jsto use the babel config file.Only check hook prop-types if not on production.
Result: treeshakeable Downshift.
Most grateful to @layershifter for contributing with this.
babel/babel#8592
babel/babel#6963