Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Add yamlint in CI system for all the yaml files in this repo #1112

Closed
allencloud opened this issue Dec 1, 2019 · 8 comments · Fixed by #1125
Closed

Add yamlint in CI system for all the yaml files in this repo #1112

allencloud opened this issue Dec 1, 2019 · 8 comments · Fixed by #1125
Assignees

Comments

@allencloud
Copy link
Contributor

allencloud commented Dec 1, 2019

Why you need it?

<img width="729" alt="23631;"29031;2019-12-01.19979;"21320;"7 00 00-13"src="https://user-images.githubusercontent.com/9465626/69912997-d32a2700-146c-119412-647870p6">

// 屏幕快照 2019-12-01 下午7 00 13

How it could be?

In CI system, when we have a yml file not formatted, error reported.

Other related information

!!!!WE STRONGLY ENCOURAGE YOU TO DESCRIBE YOUR ISSUE IN ENGLISH!!!!

@fengzixu
Copy link
Collaborator

fengzixu commented Dec 1, 2019

/assign @fengzixu

@allencloud
Copy link
Contributor Author

@fengzixu we need to first add ymalint in pouchlinter, I think. https://github.com/pouchcontainer/pouchlinter

@fengzixu
Copy link
Collaborator

fengzixu commented Dec 2, 2019

@fengzixu we need to first add ymalint in pouchlinter, I think. https://github.com/pouchcontainer/pouchlinter

Let me add it.

@fengzixu
Copy link
Collaborator

fengzixu commented Dec 3, 2019

add yamllint to pouchlinter: dragonflyoss/linter#21

@allencloud
Copy link
Contributor Author

add yamllint to pouchlinter: dragonflyoss/linter#21

@fengzixu I have merged your pull request. Now you can use image pouchcontainer/pouchlinter:v0.2.6 to modify the circle ci config.yml.

In addition, I am planning to migrate project github.com/pouchcontainer/pouchlinter to github.com/dragonflyoss/linter . I wish to hear what you think of it. @lowzj @yeya24 @starnop

@yeya24
Copy link
Collaborator

yeya24 commented Dec 4, 2019

I agree to host this linter image under dragonflyoss org. But how? Just fork the pouchlinter repo?

@allencloud
Copy link
Contributor Author

I agree to host this linter image under dragonflyoss org. But how? Just fork the pouchlinter repo?

I could migrate or transfer that to this org. @yeya24

@zhouhaibing089
Copy link
Contributor

@allencloud: Why dragonflyoss/linter and not pouchcontainer/linter?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants