-
Notifications
You must be signed in to change notification settings - Fork 773
feature: add the yamlint tool to check check all yaml files #1125
Conversation
CI failed because of a bad link. I will file a PR for it. |
CI fails:
I have tested the image
|
I know. But when I build the image of pouchlinter's master branch on my local env, misspell works fine. |
I run the build command in pouchlinter directory: |
23ce0c5
to
896897f
Compare
|
It looks like the |
@fengzixu Could you please fix all the warning and error? |
Doing |
0baa819
to
f4e9f05
Compare
Codecov Report
@@ Coverage Diff @@
## master #1125 +/- ##
======================================
Coverage 47.2% 47.2%
======================================
Files 116 116
Lines 7204 7204
======================================
Hits 3401 3401
Misses 3535 3535
Partials 268 268 Continue to review full report at Codecov.
|
1. add the yamllint into the circleci config 2. format the yaml files according to yamllint Signed-off-by: fengzixu <[email protected]>
@yeya24 @allencloud @starnop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks
LGTM |
feature: add the yamlint tool to check check all yaml files
Signed-off-by: Gaius <[email protected]>
Sign-off-by: fengzixu [email protected]
Ⅰ. Describe what this PR did
I add the yamllint tool to check yaml files in Dragonfly, so that we can ensure that their format is legal.
Ⅱ. Does this pull request fix one issue?
fix dragonflyoss/dragonfly#1112
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗?)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews