This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
feature: pass the value of dfdaemon verbose flag to dfget #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Starnop <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
==========================================
+ Coverage 46.58% 46.59% +<.01%
==========================================
Files 106 106
Lines 6187 6188 +1
==========================================
+ Hits 2882 2883 +1
Misses 3072 3072
Partials 233 233
Continue to review full report at Codecov.
|
yeya24
approved these changes
Jul 16, 2019
lowzj
reviewed
Jul 16, 2019
There was a problem hiding this comment.
LGTM
We should consider providing another more flexible way to configure the dfget rather than passing the flags of dfdaemon to dfget in the future.
- Adding a string property as the
dfget's parameters. - Different proxies may need to pass different parameters to
dfgetwhen calling it, such asurlfilter.
Yeah. We need a specific plan, and I'll submit a proposal for that. |
starnop
pushed a commit
to starnop/Dragonfly
that referenced
this pull request
Nov 27, 2019
feature: pass the value of dfdaemon verbose flag to dfget
inoc603
pushed a commit
to inoc603/Dragonfly
that referenced
this pull request
Dec 23, 2019
feature: pass the value of dfdaemon verbose flag to dfget
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Starnop [email protected]
Ⅰ. Describe what this PR did
As title described.
Ⅱ. Does this pull request fix one issue?
None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
None.
Ⅳ. Describe how to verify it
Run dfdaemon with
--verboseand you will get more logs.Ⅴ. Special notes for reviews