This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
feature: add a flag to pass timeout to dfget from dfdaemon #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yeya24 <[email protected]>
yeya24
force-pushed
the
feature/add-timeout-flag
branch
from
b671cf3 to
014fc64
Compare
yeya24
changed the title
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
==========================================
+ Coverage 46.86% 46.86% +<.01%
==========================================
Files 108 108
Lines 6226 6228 +2
==========================================
+ Hits 2918 2919 +1
Misses 3075 3075
- Partials 233 234 +1
Continue to review full report at Codecov.
|
|
In the PR #670, @lowzj and I discussed the problem that we should provide a more flexible way to configure the dfget rather than pass the flags of dfdaemon to dfget. FYI dragonflyoss/dragonfly#670 (review) And could you please help to open an issue about this problem？And we can discuss it in that issue. THX. |
|
Since we have discussed further in dragonflyoss/dragonfly#687, I will close this now. |
sungjunyoung
pushed a commit
to sungjunyoung/Dragonfly
that referenced
this pull request
May 8, 2022
* feat: add grpc metric and refactor grpc server Signed-off-by: Gaius <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yeya24 [email protected]
Ⅰ. Describe what this PR did
Add a flag to pass global timeout to dfget from dfdaemon.
This is simply a global timeout. Maybe later we can add a mechanism about setting different timeout or other dfget parameters for different tasks.
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Maybe don't need to.
Ⅳ. Describe how to verify it
use
docker pull xxxⅤ. Special notes for reviews