This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Paginate group membership #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,7 +44,8 @@ def tfstate | |||
| private | |||
|
|
|||
| def group_members_of(group) | |||
| @client.get_group(group_name: group.group_name).users.map { |user| user.user_name } | |||
| users = @client.get_group(group_name: group.group_name).map { |r| r.users }.flatten | |||
There was a problem hiding this comment.
[rubocop]
- Line is too long. [91/80] :ref
| @@ -44,7 +44,8 @@ def tfstate | |||
| private | |||
|
|
|||
| def group_members_of(group) | |||
| @client.get_group(group_name: group.group_name).users.map { |user| user.user_name } | |||
| user_query = @client.get_group(group_name: group.group_name) | |||
| user_query.map { |r| r.users }.flatten.map { |user| user.user_name } | |||
There was a problem hiding this comment.
Sorry, maximum limitation of lines is misconfigured... 🙇
Please write this in one line.
@client.get_group(group_name: group.group_name).map(&:users).flatten.map(&:user_name)
raylu
force-pushed
the
paginate_group_members
branch
from
05b34d2 to
9d7421a
Compare
| @@ -44,7 +44,7 @@ def tfstate | |||
| private | |||
|
|
|||
| def group_members_of(group) | |||
| @client.get_group(group_name: group.group_name).users.map { |user| user.user_name } | |||
| @client.get_group(group_name: group.group_name).map(&:users).flatten.map(&:user_name) | |||
There was a problem hiding this comment.
[rubocop]
- Line is too long. [93/80] :ref
1 similar comment
|
LGTM 👍 Thanks ❗ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2e55bee#diff-590760686c68c2507617371c9719e4d3 paginates groups but not their members