This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
AWS-scoped IAM policy attachments #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +65,7 @@ def entities_for_policy(policy) | |||
| end | |||
|
|
|||
| def iam_policies | |||
| @client.list_policies(scope: "Local").map(&:policies).flatten | |||
| @client.list_policies(scope: "All", only_attached: true).map(&:policies).flatten | |||
There was a problem hiding this comment.
[rubocop]
- Line is too long. [88/80] :ref
|
Sorry for late review. Code and behavior look good, but could you rebase to current master and remove changes of |
|
LGTM 👍 Thanks ❗ |
|
Excellent! Will you let me know when you cut a new gem version? |
|
@raylu Sorry for late! Terraforming v0.10.0 w/ this patch was released |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is based on stripe/paginate_group_members so includes the changes in #248.
We generate only Local-scoped policies in iamp, which is fine. We need to generate both Local- and AWS-scoped attachments though, so that users/groups/roles with AWS-scoped policies (such as
arn:aws:iam::aws:policy/AmazonS3FullAccess) are generated.