pixels for bookmarks > favorites tab #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tab or if the manage button on that tab is tapped
dus7
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Looks good! Tested bookmarks editor and focused view. I had a crash while trying to reorder favorites when run on iOS18 and compiled with SDK 18:
Expected dequeued view to be returned to the collection view in preparation for display. When the collection view's data source is asked to provide a view for a given index path, ensure that a single view is dequeued and returned to the collection view. Avoid dequeuing views without a request from the collection view.
Fix for it is pushed to 01f3721, you can cherry pick it here or I can create a separate PR for it.
samsymons
added a commit
that referenced
this pull request
Nov 14, 2024
# By Daniel Bernal (3) and others # Via GitHub * main: Remove the `ld_classic` build setting (#3575) text zoom improvements (#3509) Add support for local overrides for feature flags (#3571) pixels for bookmarks > favorites tab (#3572) Sync BSK with macos (#3561) Add possibility to stop page loading (#3553) [DuckPlayer] Overlay Usage Pixels (#3565) Update pr.yml Update pr.yml # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
brindy
added a commit
that referenced
this pull request
Jan 17, 2025
Task/Issue URL: https://app.asana.com/0/392891325557410/1208736944745857/f Tech Design URL: CC: **Description**: This reverts commit 95897a7 as the pixels are no longer required. **Steps to test this PR**: 1. Build and run the app. 2. Open bookmarks manager and tap on favorites view and smoke test it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/392891325557410/1208733952836859/f
Tech Design URL:
CC:
Description:
Pixels for bookmarks > favorites tab.
Steps to test this PR:
hasBeenFiredTodayreturns falsem_bookmarks_ui_favorites_manage_dailym_bookmarks_ui_favorites_action_dailym_bookmarks_ui_favorites_action_dailym_bookmarks_ui_favorites_action_daily