Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "pixels for bookmarks > favorites tab (#3572)" #3803

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Revert "pixels for bookmarks > favorites tab (#3572)" #3803

merged 2 commits into from
Jan 17, 2025

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jan 14, 2025

Task/Issue URL: https://app.asana.com/0/392891325557410/1208736944745857/f
Tech Design URL:
CC:

Description:
This reverts commit 95897a7 as the pixels are no longer required.

Steps to test this PR:

  1. Build and run the app.
  2. Open bookmarks manager and tap on favorites view and smoke test it.

@brindy brindy requested a review from dus7 January 14, 2025 14:10
dus7
dus7 requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@dus7 dus7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighted one thing that can potentially cause a crash.

@brindy brindy requested a review from dus7 January 16, 2025 19:25
@brindy brindy merged commit 6712a90 into main Jan 17, 2025
16 checks passed
@brindy brindy deleted the brindy/remove-pixels branch January 17, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dus7 dus7 dus7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brindy @dus7