-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Github Actions to run tests #100
Conversation
@sgerrand @jbernardo95 @msz What do you think about this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! These changes look good overall. I've added a few suggestions.
One thing missing is a link to this workflow running successfully. Would you please add this, either in the description or as a comment, to make it easier for other reviewers.
I think one other thing which needs to be done before this can be merged is enabling GitHub Actions on this repository and ensuring that at least 2-3 runs of this workflow complete successfully. |
Co-authored-by: Sasha Gerrand <[email protected]>
Note that CircleCI has supported matrices in their builds since April 2020. I only became aware of this myself late last year. |
Thank your for review! I've added a link to a successfully executed workflow into PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
When the continuous integration provider was changed by #100, the build status badge in this project's README wasn't also updated.
Just like #90, but instead of CircleCI it's better to use Github Actions.
Github Actions supports matrix builds (unlike Circle CI), and also allows to build really impressive CI/CD pipelines and PR/issues automatization. Here you can find more details about features.
Projects like ecto and phoenix are already moved to Github Actions.
Here you can find an example of successfully executed workflow: https://github.com/dolfinus/paginator/actions/runs/610852525