Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to create grpc channel on occupied port 54379 #63

Closed
sverhoeven opened this issue Mar 12, 2020 · 3 comments
Closed

Attempt to create grpc channel on occupied port 54379 #63

sverhoeven opened this issue Mar 12, 2020 · 3 comments
Assignees
@sverhoeven
Labels
bug Something isn't working

Comments

@sverhoeven
Copy link
Member

During a calibration run of the Marrmot model, the model was started with Docker over a 100 times.

Then program the printed Attempt to create grpc channel on occupied port 54379 and then it was stuck waiting for a server port to become online.
@sverhoeven sverhoeven added the bug Something isn't working label Mar 12, 2020
@sverhoeven
Copy link
Member Author

The main problem is that the library keeps track of the ports it used before and returns None as channel when it tries to reuse a port.

A secondary problem is that the timeout of the BmiClient cant be set from the BmiClientDocker constructor.

@sverhoeven
Copy link
Member Author

The fix should be applied to master branch for a 0.3.x release and the 0.2-delay5s branch for a 0.2.x release.

@sverhoeven sverhoeven self-assigned this Mar 13, 2020
sverhoeven added a commit that referenced this issue Mar 13, 2020
@sverhoeven
Added tests for create_grpc_channel
3c7c078 
Refs #63
@sverhoeven sverhoeven mentioned this issue Mar 13, 2020
Merged
sverhoeven added a commit that referenced this issue Mar 13, 2020
@sverhoeven
Dont track ports used by client
6e35068 
The are not released and the client should not care if the same port is used multiple times.

Refs #63
sverhoeven added a commit that referenced this issue Mar 13, 2020
@sverhoeven
Added timeout argument to Docker, Singularity and Subprocess clients.
17779c1 
Refs #63
goord pushed a commit that referenced this issue Mar 13, 2020
@sverhoeven
Attempt to create grpc channel on occupied port (#64)
1ef38b6 
* Added tests for create_grpc_channel

Refs #63

* Dont track ports used by client

The are not released and the client should not care if the same port is used multiple times.

Refs #63

* Added timeout argument to Docker, Singularity and Subprocess clients.

Refs #63
sverhoeven added a commit that referenced this issue Mar 13, 2020
@sverhoeven
Added tests for create_grpc_channel
1fdd8c6 
Refs #63
sverhoeven added a commit that referenced this issue Mar 13, 2020
@sverhoeven
Dont track ports used by client
659304b 
The are not released and the client should not care if the same port is used multiple times.

Refs #63
sverhoeven added a commit that referenced this issue Mar 13, 2020
@sverhoeven
Added timeout argument to Docker, Singularity and Subprocess clients.
5523d24 
Refs #63
@sverhoeven
Copy link
Member Author

Fixed in master branch and the 0.2-delay5s branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sverhoeven sverhoeven

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sverhoeven