Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to create grpc channel on occupied port #64

Merged
merged 3 commits into from
Mar 13, 2020
Merged

Attempt to create grpc channel on occupied port #64

merged 3 commits into from
Mar 13, 2020

Conversation

sverhoeven
Copy link
Member

Fix for #63

@sverhoeven sverhoeven self-assigned this Mar 13, 2020
@sverhoeven
Copy link
Member Author

The test_same_port_twice test is failing a expected. Next up is to fix code so that test succeeds.

@sverhoeven
Dont track ports used by client
6e35068 
The are not released and the client should not care if the same port is used multiple times.

Refs #63
@sverhoeven
Added timeout argument to Docker, Singularity and Subprocess clients.
17779c1 
Refs #63
@sverhoeven sverhoeven marked this pull request as ready for review March 13, 2020 11:48
@sverhoeven sverhoeven requested a review from goord March 13, 2020 11:48
@sverhoeven sverhoeven changed the base branch from master to 0.2-delay5s March 13, 2020 11:54
@goord goord merged commit 1ef38b6 into 0.2-delay5s Mar 13, 2020
@goord goord deleted the port-reuse-63 branch March 13, 2020 11:55
@sverhoeven
Copy link
Member Author

Thanks for reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goord goord goord approved these changes

Assignees

@sverhoeven sverhoeven

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverhoeven @goord