Fix: Version executions not being loaded correctly (flyteorg#647)

Fix:Veresion executions not being loaded correctly Signed-off-by: Jason Porter <[email protected]> Signed-off-by: Jason Porter <[email protected]>
eapolinario · Dec 12, 2022 · 03f3ee3 · 03f3ee3
1 parent ab19c54
commit 03f3ee3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 8 deletions.
diff --git a/packages/zapp/console/src/components/Entities/generators.ts b/packages/zapp/console/src/components/Entities/generators.ts
@@ -38,13 +38,22 @@ export const executionFilterGenerator: {
     },
   ],
   [ResourceType.UNSPECIFIED]: noFilters,
-  [ResourceType.WORKFLOW]: ({ name }) => [
-    {
-      key: 'workflow.name',
-      operation: FilterOperationName.EQ,
-      value: name,
-    },
-  ],
+  [ResourceType.WORKFLOW]: ({ name }, version) =>
+    version
+      ? [
+          {
+            key: 'workflow.version',
+            operation: FilterOperationName.EQ,
+            value: version,
+          },
+        ]
+      : [
+          {
+            key: 'workflow.name',
+            operation: FilterOperationName.EQ,
+            value: name,
+          },
+        ],
 };
 
 const workflowListGenerator = ({ project, domain }: ResourceIdentifier) =>

diff --git a/packages/zapp/console/src/components/Executions/Tables/WorkflowVersionRow.tsx b/packages/zapp/console/src/components/Executions/Tables/WorkflowVersionRow.tsx
@@ -69,7 +69,7 @@ export const WorkflowVersionRow: React.FC<WorkflowVersionRowProps> = ({
             workflow.id.version,
           )
         : [],
-    [workflow.id],
+    [workflow.id.version],
   );
 
   const executions = useWorkflowExecutions(