Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Group executions by labels #647

Open
2 of 13 tasks
katrogan opened this issue Dec 17, 2020 · 8 comments
Open
2 of 13 tasks

[Feature] Group executions by labels #647

katrogan opened this issue Dec 17, 2020 · 8 comments
Labels
enhancement New feature or request flyteadmin Issue for FlyteAdmin Service needs discussion spec-first This issue needs a spec to be created and then work. It should be an independent stream ui Admin console user interface

Comments

@katrogan
Copy link
Contributor

Motivation: Why do you think this is important?
Users can provide labels for workflow executions using launch plans at execution time. It's useful to be able to search across executions by label.

Goal: What should the final outcome look like, ideally?
There should be an endpoint exposed for searching executions by label and the UI should support search as well.

Describe alternatives you've considered
Current behavior which exposes labels in protobuf only and is retrievable for each individual execution

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

[Optional] Propose: Link/Inline

Additional context

Is this a blocker for you to adopt Flyte
Please let us know if this makes it impossible to adopt Flyte

@katrogan katrogan added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Dec 17, 2020
@jeevb
Copy link
Contributor

jeevb commented Mar 8, 2021

I think this would come in handy for teams building platforms on top of Flyte, specifically allowing users to filter/list executions with a rich set of tags (e.g. user_id, git_branch, experiment_id, etc.). project might be overkill for distinguishing between executions, but tags could be ideal!

@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Mar 8, 2021
@kumare3
Copy link
Contributor

kumare3 commented Mar 8, 2021

@jeevb do you have an idea of priority for this task - when do you guys need it?

@katrogan
Copy link
Contributor Author

katrogan commented Mar 8, 2021

hey @jeevb just fyi you can actually now filter by user_id if you're on the latest deployment of flyte/flyteadmin

@kumare3 kumare3 added the ui Admin console user interface label Mar 10, 2021
@kumare3 kumare3 added flyteadmin Issue for FlyteAdmin Service spec-first This issue needs a spec to be created and then work. It should be an independent stream labels Jun 7, 2021
@kumare3 kumare3 added this to the 1.0.0 milestone Jun 7, 2021
@kumare3
Copy link
Contributor

kumare3 commented Jun 7, 2021

@jeevb any interest in driving this spec?

@jeevb
Copy link
Contributor

jeevb commented Jun 7, 2021

Pinging relevant folks: @tvetterli-fn @MarvinBertin. What do y'all think?

@asahalyft
Copy link

asahalyft commented Aug 11, 2021

I requested for this feature in our internal channel with Flyte team. Our Business Use Case is as follows:

We create Flyte Workflows for Model Monitoring. We want to make Model Monitoring mandatory. Before we deploy any model for serving we want to make sure that there exists a workflow to monitor the model output against some ground truth. There may not be a workflow execution yet, which is fine, the user may be deploying the model just today, but there must exist a Flyte workflow.

We want to see if there are some workflows registered by a given name or some metadata or is there a provision to attach special tags while creating the workflows.

e.g. we want to add some custom tags like {model_id: 12229, model_version:v1, team: pricing, some_key:some_value} to the workflows apart from project name and the mandatory attributes - just like we can provide tags for aws objects and then search for those aws objects by those tags.

Once we are sure that a Workflow exists then we allow the model to be deployed for serving.

@katrogan
Copy link
Contributor Author

thanks @asahalyft for the background! as part of #531 we want to expand the domain of what's searchable to include descriptions, labels, tags and more.

cc @mayitbeegh

@EngHabu EngHabu modified the milestones: 1.0.0 - Phoenix!, 1.0.1 May 20, 2022
@wild-endeavor wild-endeavor removed this from the 1.0.1 milestone Jul 22, 2022
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
Fix:Veresion executions not being loaded correctly

Signed-off-by: Jason Porter <[email protected]>

Signed-off-by: Jason Porter <[email protected]>
@kumare3
Copy link
Contributor

kumare3 commented Jan 27, 2023

I think we should prioritize this feature as there are some fantastic use cases that are emerging.
cc @jsonporter / @andrewwdye / @eapolinario / @cosmicBboy / @EngHabu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flyteadmin Issue for FlyteAdmin Service needs discussion spec-first This issue needs a spec to be created and then work. It should be an independent stream ui Admin console user interface
Projects
None yet
Development

No branches or pull requests

6 participants