Monorepo import boilerplate #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the boilerplate to use go modules instead of dep and follows the changes that have already been made: * flyteorg/datacatalog#21 * flyteorg/flytepropeller#38 * flyteorg/flyteadmin#35 * flyteorg/flyteplugins#36 * flyteorg/flytestdlib#50 * flyteorg/flyteidl#27 (depends on flyteorg/flytestdlib#50 to be merged and released)
bump go version to 1.13
Installing the tools updates the files - let's use the updated files instead
* PR template for all Flyte repos
`;` could hide problems, and it is better to fail fast
* Add github_actions boilerplate * Fix numbering * Parameterize actions further to support forks * remove dockerhub push
* Updating GH workflows to not use the same hard-coded package name across all repos * doc update * Updating readme with a note about forks
* Welcome Bot Message Signed-off-by: samhita-alla <[email protected]> * Modified update.sh -- in sync with flyteorg/boilerplate repo Signed-off-by: samhita-alla <[email protected]> * Added .gitignore file Signed-off-by: samhita-alla <[email protected]> * Modified .gitignore file Signed-off-by: samhita-alla <[email protected]> * Modified the PR message Signed-off-by: samhita-alla <[email protected]> * Modified the PR message Signed-off-by: samhita-alla <[email protected]>
This addresses a TODO in `update.sh` to allow a more freeform `update.cfg`. With this change, `update.cfg` will: - Tolerate and ignore blank/whitespace-only lines - Tolerate `#` style comments, both inline (as long as preceded by whitespace) and whole-line. - Validate directories more prettily, failing with a useful message if one doesn't exist. - Explicitly disallow multiple entries per line, with a useful message. (Previously these last two things would still error, just more confusingly.) While in there, I also added an `EXIT` trap to remove the temporary directory, since otherwise failures mid-script would leave it hanging around, gradually polluting `/tmp`. Signed-off-by: Eric Fried <[email protected]>
* Welcome Bot Message Signed-off-by: samhita-alla <[email protected]> * Modified update.sh -- in sync with flyteorg/boilerplate repo Signed-off-by: samhita-alla <[email protected]> * Added .gitignore file Signed-off-by: samhita-alla <[email protected]> * Modified .gitignore file Signed-off-by: samhita-alla <[email protected]> * Modified the PR message Signed-off-by: samhita-alla <[email protected]> * Modified the PR message Signed-off-by: samhita-alla <[email protected]> * Update Boilerplate Signed-off-by: Samhita Alla <[email protected]> * Updated permissions of update.sh file Signed-off-by: Samhita Alla <[email protected]> * Updated update.sh Signed-off-by: Samhita Alla <[email protected]>
* Welcome Bot Message Signed-off-by: samhita-alla <[email protected]> * Modified update.sh -- in sync with flyteorg/boilerplate repo Signed-off-by: samhita-alla <[email protected]> * Added .gitignore file Signed-off-by: samhita-alla <[email protected]> * Modified .gitignore file Signed-off-by: samhita-alla <[email protected]> * Modified the PR message Signed-off-by: samhita-alla <[email protected]> * Modified the PR message Signed-off-by: samhita-alla <[email protected]> * Update Boilerplate Signed-off-by: Samhita Alla <[email protected]> * Updated permissions of update.sh file Signed-off-by: Samhita Alla <[email protected]> * Updated update.sh Signed-off-by: Samhita Alla <[email protected]> * Modified config.yml path in update.sh Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: wild-endeavor <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
* Update update.sh script after everything is done Signed-off-by: Yuvraj <[email protected]> * Added end2end in boilerplate Signed-off-by: Yuvraj <[email protected]> * More changes Signed-off-by: Yuvraj <[email protected]> * More changes Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
* Added protoc-gen-doc dependency for IDL doc generation Signed-off-by: Prafulla Mahindrakar <[email protected]> * Formatting change Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
* Added boilerplate automation Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
…g#33) * Update PR Template to automatically close issues when merged Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add instructions to know when to remove 'fixes' keyword Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
* revert go version in support tools Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
…lag (flyteorg#54) * Use click to define parameters to functional tests script Signed-off-by: Eduardo Apolinario <[email protected]> * Modify invocation of script to add boolean flag Signed-off-by: Eduardo Apolinario <[email protected]> * Revert "Modify invocation of script to add boolean flag" This reverts commit 0f74a78d5b768649dbdf047b83327fe20a361966. Signed-off-by: Eduardo Apolinario <[email protected]> * Modify invocation of functional test script Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Prafulla Mahindrakar <[email protected]>
…org#57) Signed-off-by: Prafulla Mahindrakar <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Yuvraj <[email protected]> Co-authored-by: Yuvraj <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Yuvraj <[email protected]> Co-authored-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
* update perms of code_of_conduct update.sh Signed-off-by: Samhita Alla <[email protected]> * Remove welcome-bot Signed-off-by: Samhita Alla <[email protected]>
…ctional OSS testing [ and opta/deployment, etc ] (flyteorg#67) Signed-off-by: Bruce Arctor <[email protected]>
* update workflow name Signed-off-by: Kevin Su <[email protected]> * update workflow name Signed-off-by: Kevin Su <[email protected]> Signed-off-by: Kevin Su <[email protected]>
* It will add a lite version of the functional test for quick testing Large functional test good for end 2 end test of releases, but for quick regression test we don't need to validate all workflows, Few workflows will work fine Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
flyteorg#72) Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
* Update functional tests to reflect the new names Signed-off-by: eduardo apolinario <[email protected]> * Fix lite tests Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
* Fix name of non-P0 tests Signed-off-by: eduardo apolinario <[email protected]> * Comment pandera test again Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
…into monorepo--import-boilerplate Signed-off-by: Eduardo Apolinario <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import boilerplate