chore: Remove unused Che Postgres image

[mkuznyetsov]

Signed-off-by: Mykhailo Kuznietsov [email protected]

What does this PR do?

Che Postgres image is not used anymore, so it will be replaced by this one - https://quay.io/repository/eclipse/che--centos--postgresql-96-centos7?tab=tags

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#21349

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[tolusha]

We can't replace
image: quay.io/eclipse/che-postgres:next
on
image: quay.io/eclipse/che--centos-postgresql-96-centos7:9.6-b681d78125361519180a6ac05242c296f8906c11eab7e207b5ca9a89b6344392

They are quite different images.

[nickboldt]

We can't replace image: quay.io/eclipse/che-postgres:next on image: quay.io/eclipse/che--centos-postgresql-96-centos7:9.6-b681d78125361519180a6ac05242c296f8906c11eab7e207b5ca9a89b6344392

They are quite different images.

But the only place we reference quay.io/eclipse/che-postgres is in the helm charts. In the CSV, we use quay.io/eclipse/che--centos-postgresql-96-centos7:9.6-b681d78125361519180a6ac05242c296f8906c11eab7e207b5ca9a89b6344392 and the 13.3 version too.

Is the helm chart outdated? or do we actually need this old image there? And if we need it there, why do we use different postgres images for OpenShift?

See also eclipse-che/che#21348 and eclipse-che/che-docs#2313 (which has already been merged). Was that an error too?

[tolusha]

Since installation with Helm is not equal to installation with operator some images are different.
Here is the Dockerfile [1] Besides PostgreSQL 9.6 image, it contains some configuration that is required only for Helm
So, simple replacement won't work. My suggestions are:

1. Don't touch anything related to Helm here. Basically these charts are outdated, but maybe someone from community uses them
   or
2. Completely remove everything related to HelmCharts

[1] https://github.com/eclipse-che/che-server/blob/main/dockerfiles/postgres/Dockerfile

[nickboldt]

I guess this won't be merged. Sorry about that @mkuznyetsov -- should have spent more time discussing the requirement w/ @tolusha before we launched into a solution. :D