Update link after switching from `master` to `main` #1149

azatsarynnyy · 2021-06-18T19:33:45Z

Signed-off-by: Artem Zatsarynnyi [email protected]

What does this PR do?

Update link after switching from master to main.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20000

How to test this PR?

docker-build jobs should pass.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Signed-off-by: Artem Zatsarynnyi <[email protected]>

che-bot · 2021-06-18T19:40:47Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1149
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1149

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

che-bot · 2021-06-18T19:45:44Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1149
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1149

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

codecov · 2021-06-18T19:49:30Z

Codecov Report

❗ No coverage uploaded for pull request base (main@1031e2e). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1149   +/-   ##
=======================================
  Coverage        ?   32.78%           
=======================================
  Files           ?      290           
  Lines           ?     9885           
  Branches        ?     1457           
=======================================
  Hits            ?     3241           
  Misses          ?     6641           
  Partials        ?        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1031e2e...06e5b0a. Read the comment docs.

azatsarynnyy · 2021-06-18T20:05:39Z

The HappyPath tests are failed due to the known problem https://www.eclipse.org/lists/che-dev/msg04194.html.
The change here is build-related only. All the build jobs are passed. So, merging.

dmytro-ndp · 2021-06-19T19:56:24Z

@azatsarynnyy:

The HappyPath tests are failed due to the known problem https://www.eclipse.org/lists/che-dev/msg04194.html.
The change here is build-related only. All the build jobs are passed. So, merging.

Actually, Happy path PR check failed because of different problem: che-theia build failure:
#1149 (comment)

[2021-06-18T19:45:16.485Z]   ● Test Extensions › should skip clonning if source is an existing folder (and not a git uri to clone) and use it as the clonedDir
[2021-06-18T19:45:16.485Z] 
[2021-06-18T19:45:16.485Z]     Command failed: git init -b main
[2021-06-18T19:45:16.485Z]     error: unknown switch `b'
[2021-06-18T19:45:16.485Z]     usage: git init [-q | --quiet] [--bare] [--template=<template-directory>] [--shared[=<permissions>]] [directory]
[2021-06-18T19:45:16.485Z] 
[2021-06-18T19:45:16.485Z]         --template <template-directory>
[2021-06-18T19:45:16.485Z]                               directory from which templates will be used
[2021-06-18T19:45:16.485Z]         --bare                create a bare repository
[2021-06-18T19:45:16.485Z]         --shared[=<permissions>]
[2021-06-18T19:45:16.485Z]                               specify that the git repository is to be shared amongst several users
[2021-06-18T19:45:16.485Z]         -q, --quiet           be quiet
[2021-06-18T19:45:16.485Z]         --separate-git-dir <gitdir>
[2021-06-18T19:45:16.485Z]                               separate git dir from working tree
[2021-06-18T19:45:16.485Z] 
[2021-06-18T19:45:16.485Z]       76 |
[2021-06-18T19:45:16.485Z]       77 |     function initGit(cwd: string) {
[2021-06-18T19:45:16.485Z]     > 78 |         cp.execSync('git init -b main', { cwd });
[2021-06-18T19:45:16.485Z]          |            ^
[2021-06-18T19:45:16.485Z]       79 |         cp.execSync('git config --local user.name "test user"', { cwd });
[2021-06-18T19:45:16.485Z]       80 |         cp.execSync('git config --local user.email [email protected]', { cwd });
[2021-06-18T19:45:16.485Z]       81 |         cp.execSync(`git add ${cwd}`, { cwd });
[2021-06-18T19:45:16.485Z] 
[2021-06-18T19:45:16.485Z]       at initGit (tests/init-sources/init-sources.spec.ts:78:12)
[2021-06-18T19:45:16.485Z]       at tests/init-sources/init-sources.spec.ts:70:9
[2021-06-18T19:45:16.486Z]       at step (tests/init-sources/init-sources.spec.ts:42:23)
[2021-06-18T19:45:16.486Z]       at Object.next (tests/init-sources/init-sources.spec.ts:23:53)
[2021-06-18T19:45:16.486Z]       at fulfilled (tests/init-sources/init-sources.spec.ts:14:58)
[2021-06-18T19:45:16.486Z] 
[2021-06-18T19:45:16.486Z] PASS tests/command.spec.ts
[2021-06-18T19:45:16.752Z] PASS tests/cdn/boostrap.spec.ts
[2021-06-18T19:45:16.752Z] PASS tests/cli-error.spec.ts
[2021-06-18T19:45:16.752Z] PASS tests/link.spec.ts
[2021-06-18T19:45:16.752Z] PASS tests/cdn/webpack-loader.spec.ts
[2021-06-18T19:45:23.444Z] -------------------------|---------|----------|---------|---------|-----------------------------
[2021-06-18T19:45:23.444Z] File                     | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s           
[2021-06-18T19:45:23.444Z] -------------------------|---------|----------|---------|---------|-----------------------------
[2021-06-18T19:45:23.444Z] All files                |   77.59 |    69.16 |   80.52 |   77.76 |                             
[2021-06-18T19:45:23.445Z]  src                     |   73.94 |    57.58 |   77.52 |   73.82 |                             
[2021-06-18T19:45:23.445Z]   cdn.ts                 |     100 |      100 |     100 |     100 |                             
[2021-06-18T19:45:23.445Z]   clean.ts               |     100 |       75 |     100 |     100 | 45                          
[2021-06-18T19:45:23.445Z]   cli-error.ts           |     100 |       50 |     100 |     100 | 17                          
[2021-06-18T19:45:23.445Z]   command.ts             |     100 |      100 |     100 |     100 |                             
[2021-06-18T19:45:23.445Z]   generate-assembly.ts   |   50.91 |    14.29 |      40 |      54 | 39-74                       
[2021-06-18T19:45:23.445Z]   index.ts               |       0 |      100 |     100 |       0 | 12-14                       
[2021-06-18T19:45:23.445Z]   init-sources.ts        |   93.64 |    84.21 |     100 |   93.25 | 134,164-167,294-300,323-326 
[2021-06-18T19:45:23.445Z]   init.ts                |   42.35 |    18.52 |   33.33 |   42.65 | 54-100,104-110,115-118      
[2021-06-18T19:45:23.445Z]   json-utils.ts          |   23.08 |        0 |       0 |      25 | 20-23,28-33                 
[2021-06-18T19:45:23.445Z]   link.ts                |   97.06 |     62.5 |     100 |    96.3 | 52                          
[2021-06-18T19:45:23.445Z]   logger.ts              |     100 |      100 |     100 |     100 |                             
[2021-06-18T19:45:23.445Z]   production.ts          |     100 |      100 |     100 |     100 |                             
[2021-06-18T19:45:23.445Z]   repository.ts          |     100 |       80 |     100 |     100 | 50,58                       
[2021-06-18T19:45:23.445Z]   update-dependencies.ts |       0 |        0 |       0 |       0 | 16-83                       
[2021-06-18T19:45:23.445Z]   yargs.ts               |       0 |        0 |       0 |       0 | 11-142                      
[2021-06-18T19:45:23.445Z]   yarn.ts                |   92.39 |    80.65 |    87.5 |   95.06 | 215-217,224-225             
[2021-06-18T19:45:23.445Z]  src/cdn                 |   95.45 |      100 |      96 |   95.27 |                             
[2021-06-18T19:45:23.445Z]   base.ts                |   96.77 |      100 |     100 |   96.55 | 97-98                       
[2021-06-18T19:45:23.445Z]   bootstrap.ts           |     100 |      100 |     100 |     100 |                             
[2021-06-18T19:45:23.445Z]   html-template.ts       |     100 |      100 |     100 |     100 |                             
[2021-06-18T19:45:23.445Z]   webpack-customizer.ts  |     100 |      100 |     100 |     100 |                             
[2021-06-18T19:45:23.445Z]   webpack-loader.ts      |     100 |      100 |     100 |     100 |                             
[2021-06-18T19:45:23.445Z]   webpack.config.ts      |       0 |      100 |       0 |       0 | 11-19                       
[2021-06-18T19:45:23.445Z] -------------------------|---------|----------|---------|---------|-----------------------------
[2021-06-18T19:45:23.445Z] 
[2021-06-18T19:45:23.445Z] Test Suites: 1 failed, 15 passed, 16 total
[2021-06-18T19:45:23.445Z] Tests:       13 failed, 60 passed, 73 total
[2021-06-18T19:45:23.445Z] Snapshots:   0 total
[2021-06-18T19:45:23.445Z] Time:        16.849 s
[2021-06-18T19:45:23.445Z] Ran all test suites.
[2021-06-18T19:45:23.445Z] Force exiting Jest: Have you considered using `--detectOpenHandles` to detect async operations that kept running after all tests finished?
[2021-06-18T19:45:23.445Z] error Command failed with exit code 1.
[2021-06-18T19:45:23.445Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[2021-06-18T19:45:23.445Z] error Command failed with exit code 1.
[2021-06-18T19:45:23.445Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[2021-06-18T19:45:23.445Z] error Command failed with exit code 1.
[2021-06-18T19:45:23.445Z] info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
[2021-06-18T19:45:23.445Z] Copying Che-Theia generator
[2021-06-18T19:45:23.445Z] cp: cannot stat ‘/mnt/hudson_workspace/workspace/Che/e2e/minikube/pr-check/che-theia-pr-check/che-theia/dockerfiles/theia-dev/../../generator/eclipse-che-theia-generator.tgz’: No such file or directory

azatsarynnyy · 2021-06-20T07:12:31Z

Thanks @dmytro-ndp!
Note, Git version, used in HappyPath test, should be updated to 2.28, at least. To recognize -b argument in git init -b main command that is used in unit tests now.

Command failed: git init -b main
[2021-06-18T19:45:16.485Z]     error: unknown switch `b'

benoitf · 2021-06-20T07:18:03Z

maybe we could do git init and then git checkout -b to avoid to upgrade git in jobs ?

azatsarynnyy · 2021-06-20T07:44:17Z

maybe we could do git init and then git checkout -b to avoid to upgrade git in jobs ?

sure, we could do that, as an alternative approach, if it won't be possible to update git

azatsarynnyy · 2021-06-20T08:04:07Z

I've prepared a PR that will allow continuing to use git < 2.28 for HappyPath tests.
#1150
Feel free to merge it if it will be needed.

Signed-off-by: Artem Zatsarynnyi <[email protected]>

azatsarynnyy requested review from benoitf, RomanNikitenko and vzhukovs as code owners June 18, 2021 19:33

azatsarynnyy mentioned this pull request Jun 18, 2021

refactor: Update master branch mentioning to main #1147

Merged

9 tasks

benoitf approved these changes Jun 18, 2021

View reviewed changes

fix: Update link after switching from master to main

06e5b0a

Signed-off-by: Artem Zatsarynnyi <[email protected]>

azatsarynnyy force-pushed the main-switch branch from 5750630 to 06e5b0a Compare June 18, 2021 19:37

azatsarynnyy merged commit b751774 into main Jun 18, 2021

azatsarynnyy deleted the main-switch branch June 18, 2021 20:05

che-bot added this to the 7.33 milestone Jun 18, 2021

azatsarynnyy mentioned this pull request Jun 20, 2021

Adapt unit tests to git 1.8 used for HappyPath tests #1150

Merged

9 tasks

dmytro-ndp pushed a commit that referenced this pull request Jul 21, 2021

fix: Update link after switching from master to main (#1149)

ce00335

Signed-off-by: Artem Zatsarynnyi <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update link after switching from `master` to `main` #1149

Update link after switching from `master` to `main` #1149

azatsarynnyy commented Jun 18, 2021 •

edited

Loading

che-bot commented Jun 18, 2021

che-bot commented Jun 18, 2021

codecov bot commented Jun 18, 2021 •

edited

Loading

azatsarynnyy commented Jun 18, 2021

dmytro-ndp commented Jun 19, 2021

azatsarynnyy commented Jun 20, 2021

benoitf commented Jun 20, 2021

azatsarynnyy commented Jun 20, 2021

azatsarynnyy commented Jun 20, 2021

Update link after switching from master to main #1149

Update link after switching from master to main #1149

Conversation

azatsarynnyy commented Jun 18, 2021 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

Happy Path Channel

che-bot commented Jun 18, 2021

che-bot commented Jun 18, 2021

codecov bot commented Jun 18, 2021 • edited Loading

Codecov Report

azatsarynnyy commented Jun 18, 2021

dmytro-ndp commented Jun 19, 2021

azatsarynnyy commented Jun 20, 2021

benoitf commented Jun 20, 2021

azatsarynnyy commented Jun 20, 2021

azatsarynnyy commented Jun 20, 2021

Update link after switching from `master` to `main` #1149

Update link after switching from `master` to `main` #1149

azatsarynnyy commented Jun 18, 2021 •

edited

Loading

codecov bot commented Jun 18, 2021 •

edited

Loading