Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Adapt unit tests to git 1.8 used for HappyPath tests #1150

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Jun 20, 2021

Signed-off-by: Artem Zatsarynnyi [email protected]

What does this PR do?

Adapts unit tests to git 1.8 used for HappyPath tests. As git init -b main requires git > 2.28.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

See #1149 (comment)

How to test this PR?

When building the images for HappyPath tests there shouldn't be an error like #1149 (comment)

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

@codecov
Copy link

codecov bot commented Jun 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@b751774). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1150   +/-   ##
=======================================
  Coverage        ?   32.78%           
=======================================
  Files           ?      290           
  Lines           ?     9885           
  Branches        ?     1457           
=======================================
  Hits            ?     3241           
  Misses          ?     6641           
  Partials        ?        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b751774...c299f59. Read the comment docs.

@che-bot
Copy link
Contributor

che-bot commented Jun 20, 2021

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1150
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1150

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has fixed build step in Happy Path PR check.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants