Improve the connection pool lookup messages #25270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dmiya3 <[email protected]>
dmatej
reviewed
Dec 6, 2024
...e/src/main/java/com/sun/enterprise/connectors/service/ConnectorResourceAdminServiceImpl.java
Show resolved
Hide resolved
Signed-off-by: dmiya3 <[email protected]>
dmatej
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to change the log level of the following message from WARNING to INFO because this warning is printed in the server log even though the lazy-loading works as expected.
I would also like to make the messages a little better when the lookup ultimately fails, so it's easier for those unfamiliar with the internal work (two lookups, accounting for lazy-loading) to understand.
Signed-off-by: dmiya3 [email protected]