Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the connection pool lookup messages #25270

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Improve the connection pool lookup messages #25270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d7cfa8
Improve connection pool lookup messages
dmiya3 Dec 2, 2024
a388c86
Remove duplicate lookup failure logs
dmiya3 Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...rc/main/java/com/sun/enterprise/connectors/service/ConnectorResourceAdminServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2022 Contributors to the Eclipse Foundation
* Copyright (c) 2022, 2024 Contributors to the Eclipse Foundation
* Copyright (c) 1997, 2018 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
Expand Down Expand Up @@ -66,15 +66,14 @@ public void createConnectorResource(ResourceInfo resourceInfo, PoolInfo poolInfo
try {
ccp = (ConnectorConnectionPool) namingService.lookup(poolInfo, jndiNameForPool);
} catch (NamingException ne) {
_logger.log(Level.WARNING,
_logger.log(Level.INFO,
"Probably the pool {0} is not yet initialized (lazy-loading), trying to check ...", poolInfo);
try {
checkAndLoadPool(poolInfo);
ccp = (ConnectorConnectionPool) namingService.lookup(poolInfo, jndiNameForPool);
} catch (NamingException e) {
_logger.log(Level.SEVERE, "Second lookup failed for {0}: {1}", new Object[] {poolInfo, e});
dmatej marked this conversation as resolved.
Show resolved Hide resolved
throw new ConnectorRuntimeException(
"Second lookup failed again for pool name " + jndiNameForPool + " or " + poolInfo, ne);
"Failed to lookup pool name " + jndiNameForPool + " or " + poolInfo, ne);
}
}

Expand Down