Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update target platform to r2024-09 #249

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Update target platform to r2024-09 #249

merged 3 commits into from
Dec 6, 2024

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Dec 4, 2024

What it does

  • Update target platforms.
    -New default target Eclipse 2024-09
    • New minimum baseline Eclipse 2023-12
    • Switch to jarkarta variant of lsp4j websocket
    • Switch to Jetty 12

Builds on top of: #24

Changes done on top:

  • Remove outdated targets
  • Adjust version ranges
  • Create a new target definition for the minimum supported version (2023-12)
  • Restore explicit reexport of certain packages to maintain backwards compatibility
  • Fix and align m2 build
  • Add possibility to change the target platform of the p2 build with the p2.target property

Part of eclipse-glsp/glsp#1397

How to test

Building and running the example via CLI should work as expected
Test the following:
P2:

  • mvn clean verify -Pp2
  • mvn clean verifiy -Dp2.target=r2023-12 (to build against the minimum p2 target)
    M2:
  • mvn clean verify -Pm2
    Build the example fatjar
  • mvn clean verify -Pm2 -Pfatjar
    Start the example jar
  • java -jar examples/org.eclipse.glsp.example.workflow/target/org.eclipse.glsp.example.workflow-2.3.0-SNAPSHOT-glsp.jar -p 80
    81 --websocket
    (and open the example diagram.html of the standalone client example)

Eclipse version used for development: 2024-06 Modelling Tools
Also tested with 2023-12 Modellingtools

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

frankbenoit and others added 2 commits November 28, 2024 00:32
javax to jakarta, jetty 10.x to 12.0.12
- Update target platforms.
   -New default target Eclipse 2024-09
  - New minimum baseline Eclipse 2023-12
  - Switch to jarkarta variant of lsp4j websocket
  - Switch to Jetty 12

Builds on top of: #24

Changes done on top:
- Remove outdated targets
- Adjust version ranges
- Create a new target definition for the minimum supported version (2023-12)
- Restore explicit reexport of certain packages to maintain backwards compatibility
- Fix and align m2 build
- Add possibility to change the target platform of the p2 build with the p2.target property

Part of eclipse-glsp/glsp#1397
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, thank you very much, Tobias! I built and ran the server from maven and directly from Eclipse. It all seemed to work as expected. I just have a minor comment but nothing too important.

@tortmayr
Copy link
Contributor Author

tortmayr commented Dec 6, 2024

@martin-fleck-at The target for r2023-12 has been updated to use elk 0.8.1

@tortmayr tortmayr merged commit fe1ed99 into master Dec 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants