#140 Improve extendibility of DefaultGLSPServer #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid private members in the default implementation for easier customization in subclasses. Follow-up for eclipse-glsp/client/issues/140
martin-fleck-at
approved these changes
Nov 6, 2020
dseebacher
pushed a commit
to dseebacher/glsp-server
that referenced
this pull request
Jan 1, 2021
MatthiasHofstaetter
pushed a commit
to MatthiasHofstaetter/glsp-server
that referenced
this pull request
Dec 21, 2024
- Add Readonly support to ModelState and disable operation execution when in readonly mode. - Introduce SetEditMode action - Refactor ModelState/GraphicalModelState - Rename FilebaseModelfactory to JsonFileModelFactory and remove default binding - Improve parsing methods for ClientOptions (proper handling of null args) part of eclipse-glsp/glsp/issues/87
MatthiasHofstaetter
pushed a commit
to MatthiasHofstaetter/glsp-server
that referenced
this pull request
Dec 21, 2024
MatthiasHofstaetter
pushed a commit
to MatthiasHofstaetter/glsp-server
that referenced
this pull request
Dec 21, 2024
…glsp#87) Avoid private members in the default implementation for easier customization in subclasses. Follow-up for eclipse-glsp/client/issues/140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid private members in the default implementation for easier customization in subclasses.
Follow-up for eclipse-glsp/client/issues/140