Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improved webapp zero-config tests #42

Conversation

manusa
Copy link
Member

@manusa manusa commented May 22, 2020

Relates to:

- Test is compliant for new updated base images (eclipse-jkube/jkube#206)
- Service edited and switched to NodePort to verify port response
- Added k8s:log goal verifications
@rohanKanojia rohanKanojia merged commit f08a8ef into eclipse-jkube:master May 22, 2020
@manusa
Copy link
Member Author

manusa commented May 22, 2020

Was not ready yet, failing test (NodePort is not ready when performing request, need to add a wait condition). I'll submit a follow-up patch shortly.

@manusa
Copy link
Member Author

manusa commented May 22, 2020

It did work when invoking through IDE though (problem is that when running on Maven, it's quicker, so NodePort is not ready)

@rohanKanojia
Copy link
Member

ah, sorry.

@manusa manusa deleted the feat/improved-webapp-zero-config branch May 22, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants