feat: WebAppGenerator tomcat handler uses jkube/jkube-tomcat9-binary-s2i for Docker and S2I builds #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
============================================
+ Coverage 26.28% 26.73% +0.45%
- Complexity 1589 1620 +31
============================================
Files 350 350
Lines 18295 18310 +15
Branches 2806 2803 -3
============================================
+ Hits 4808 4895 +87
+ Misses 12929 12853 -76
- Partials 558 562 +4
Continue to review full report at Codecov.
|
…s2i for Docker and S2I builds. - Fixed deployment to ROOT path for all webapps - Added complete coverage to WebAppGenerator Signed-off-by: Marc Nuri <[email protected]>
manusa
force-pushed
the
feature/tomcat9-base-images
branch
from
7e90c68
to
2f51912
Compare
|
SonarCloud Quality Gate failed.
|
manusa
added a commit
to marcnuri-forks/jkube-integration-tests
that referenced
this pull request
May 22, 2020
- Test is compliant for new updated base images (eclipse-jkube/jkube#206) - Service edited and switched to NodePort to verify port response - Added k8s:log goal verifications
rohanKanojia
approved these changes
May 22, 2020
devang-gaur
approved these changes
May 22, 2020
rohanKanojia
pushed a commit
to eclipse-jkube/jkube-integration-tests
that referenced
this pull request
May 22, 2020
- Test is compliant for new updated base images (eclipse-jkube/jkube#206) - Service edited and switched to NodePort to verify port response - Added k8s:log goal verifications
anandrkskd
pushed a commit
to anandrkskd/jkube-integration-tests
that referenced
this pull request
May 28, 2020
- Test is compliant for new updated base images (eclipse-jkube/jkube#206) - Service edited and switched to NodePort to verify port response - Added k8s:log goal verifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as base image
n.b. k8s-webapp tests will fail due to assertions based on previous image assumptions (number of ports). Tests to be updated once the PR is merged (also with more test cases).