Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenShift compliant git/vcs annotations #173

Closed
manusa opened this issue May 4, 2020 · 0 comments · Fixed by #212
Closed

Use OpenShift compliant git/vcs annotations #173

manusa opened this issue May 4, 2020 · 0 comments · Fixed by #212
Assignees
Milestone

Comments

@manusa
Copy link
Member

manusa commented May 4, 2020

Description

As of now, Elipse JKube adds the following annotations to every generated resource manifest jkube.io/git-branch, jkube.io/git-url, jkube.io/git-commit.

We should include or replace the ones recommended in @gorkem app-label guidelines(app.openshift.io/vcs-uri, app.openshift.io/vcs-ref).

https://github.com/eclipse/jkube/blob/b294c87433532762234a61e95b3d939749b4aff8/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/GitEnricher.java#L57-L81

See also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants