Fix #173: Use OpenShift compliant git/vcs annotations #212
Conversation
| } | ||
| }); | ||
| } | ||
|
|
||
| protected void addAnnotations(PlatformMode platformMode, Map<String, String> annotations, String gitRemoteUrl, String branch, String commitId) { |
There was a problem hiding this comment.
It would be better if the function was pure and instead of creating side effects in the input annotations variable you returned a new Map with the annotations. This map can then be appended (if applicable) to the existing variable using putAll.
| } | ||
| }); | ||
| } | ||
|
|
||
| protected static Map<String, String> addAnnotations(PlatformMode platformMode, String gitRemoteUrl, String branch, String commitId) { |
There was a problem hiding this comment.
nit: this method is not adding any annotations but generating/inferring them. Method should be named something like getAnnotations generateAnnotations inferAnnotations or sth like that.
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
============================================
+ Coverage 26.76% 26.80% +0.04%
- Complexity 1626 1630 +4
============================================
Files 350 351 +1
Lines 18308 18320 +12
Branches 2801 2800 -1
============================================
+ Hits 4900 4911 +11
Misses 12848 12848
- Partials 560 561 +1
Continue to review full report at Codecov.
|
...e-kit/enricher/generic/src/test/java/org/eclipse/jkube/enricher/generic/GitEnricherTest.java
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed.
|
Fix #173