-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hacktoberfest] ConfigMap fields may be 'final' #1797 #1805
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #1805 (2022-10-12T02:06:20Z) ⚙️ JKube E2E Tests (3228915900)
|
Hi @ShubhraSuman In order to contribute to Eclipse, you would need to create an Eclipse Account and Sign Eclipse Contributor Agreement. Once you've created an eclipse account you would need to update your commit message with a Signed-off-by: footer. You can do it like this: Amend your previous commit with signed off footer git commit --amend --signoff |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #1805 +/- ##
=========================================
Coverage 53.00% 53.00%
Complexity 3938 3938
=========================================
Files 464 464
Lines 20745 20745
Branches 2809 2809
=========================================
Hits 10996 10996
Misses 8623 8623
Partials 1126 1126
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
[Hacktoberfest] ConfigMap fields may be 'final', fixes #1797
Type of change
test, version modification, documentation, etc.)